Repository navigation
Book scan: domain gate for books outside the lexicon's language (mirror of #35, with QA fixes) - #39
Merged
Merged
Conversation
…by default) Config.book_domain_max (CLI --book-domain-max): before reporting, a book scan measures the share of the book's words (3+ letters, not abbreviations) that the lexicon has at most rare_max times apart from the book itself. Above the threshold (and with at least book_domain_min_words such words) the rarity-based findings (book_scan.DOMAIN_TYPES: edit1_*, spelling_variant, missing_space, lost_quotes, real_word) are left out, the log says so and the result carries a `domain` entry. Final-letter, OCR profile and extra-space findings stay. Off (0): no `domain` key, output unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # magiah/cli.py
…nimum - split_alternatives (and real_word.hints) follow the findings the gate leaves out; no is_primary for a gone missing_space finding - gate refuses (logged, domain.refused small/partial) when the lexicon is under book_domain_min_lexicon words or was built partial - minimum is occurrences AND distinct words (book_domain_min_types, 100) - document the own-count rule (same as only_this_book / real_word), test it - UI labels for the new settings, README updates, tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of #35 (fork PR; CodeQL does not run on forks) plus QA fixes: consistent drops of split_alternatives, refusal on a weak/partial lexicon, distinct-word minimum, UI wiring.
🤖 Generated with Claude Code