Skip to content

chore: adjusting the setup#350

Merged
dinahmaccodes merged 5 commits into
Navin-xmr:mainfrom
m1s0g1:Implementation
May 30, 2026
Merged

chore: adjusting the setup#350
dinahmaccodes merged 5 commits into
Navin-xmr:mainfrom
m1s0g1:Implementation

Conversation

@m1s0g1
Copy link
Copy Markdown
Contributor

@m1s0g1 m1s0g1 commented Apr 29, 2026

Description

Summary

What Changed

  • Validation: Payment-milestone rules, deadlines, participant checks, token validation.
  • Token: token_address added to ShipmentInput/Shipment and persisted per-shipment.
  • Escrow: deposit/release/refund and events use shipment token_address.
  • Errors: New validation NavinError variants + messages.
  • Tests: Core validation tests updated; rest of suite requires fixture updates.

Files

  • Edited: validation.rs, lib.rs, error_map.rs, events.rs, storage.rs

Breaking Changes

  • API: ShipmentInput/Shipment now include token_address — callers and tests must supply it.
  • Events: Escrow event payloads include token_address.

Testing

cargo test -p shipment
cargo clippy -p shipment --all-targets --all-features -- -D warnings
cargo build --target wasm32-unknown-unknown --release -p shipment

Checklist

  • Validation implemented: Yes
  • Per-shipment token persisted: Yes
  • Escrow ops updated: Yes
  • Validation tests updated: Partially (core done)
  • Full test-suite updated: No (needs bulk fixture edits)

Closes #142
Closes #226
Closes #330
Closes #331

@m1s0g1 m1s0g1 marked this pull request as ready for review April 29, 2026 01:46
@dinahmaccodes
Copy link
Copy Markdown
Contributor

please finish up your PR @m1s0g1

@m1s0g1
Copy link
Copy Markdown
Contributor Author

m1s0g1 commented May 1, 2026

finishing pr today

@dinahmaccodes
Copy link
Copy Markdown
Contributor

complete your pr

@m1s0g1
Copy link
Copy Markdown
Contributor Author

m1s0g1 commented May 30, 2026

yes ma
sorry for the delay

@m1s0g1
Copy link
Copy Markdown
Contributor Author

m1s0g1 commented May 30, 2026

fixing the bugs

@dinahmaccodes dinahmaccodes merged commit 6e35f7b into Navin-xmr:main May 30, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants