Skip to content

chore: align ShipmentStatus with backend; add shared mapping and tests#194

Merged
kingksjo merged 1 commit into
Navin-xmr:mainfrom
nikkybel:fix/shipment-status-align
May 31, 2026
Merged

chore: align ShipmentStatus with backend; add shared mapping and tests#194
kingksjo merged 1 commit into
Navin-xmr:mainfrom
nikkybel:fix/shipment-status-align

Conversation

@nikkybel
Copy link
Copy Markdown
Contributor

close #191
close #189
close #190

Copy link
Copy Markdown

@ahmedabbas52233-a11y ahmedabbas52233-a11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"LGTM! Clean refactor — the shared mapping approach is much better than scattered hardcoded strings. All tests pass and the status alignment looks correct across all files. Thanks for fixing #189, #190, and #191 in one go!

@kingksjo kingksjo merged commit 4c2781d into Navin-xmr:main May 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants