fix: rename proof upload field from notes to recipientSignatureName#196
Open
ahmedabbas52233-a11y wants to merge 2 commits into
Open
Conversation
- Update uploadProof parameter from optional notes to required recipientSignatureName - Change FormData field key from notes to recipientSignatureName - Align API client with backend contract for delivery proof uploads Closes Navin-xmr#179
- Update uploadProof parameter from optional notes to required recipientSignatureName - Change FormData field key from notes to recipientSignatureName - Add *.tsbuildinfo to .gitignore to prevent build cache from being committed - Align API client with backend contract for delivery proof uploads Closes Navin-xmr#179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #179
Updates the proof upload API method to use the correct field name expected by the backend.
Changes
uploadProofparameter fromnotes?: stringtorecipientSignatureName: string."notes"to"recipientSignatureName"Testing
pnpm run lintpassespnpm run buildpassespnpm run devstarts without errors