Address review feedback on Windows Port Monitor persistence module - #13
Open
prithvee07 wants to merge 1 commit into
Open
Address review feedback on Windows Port Monitor persistence module#13prithvee07 wants to merge 1 commit into
prithvee07 wants to merge 1 commit into
Conversation
Applies the requested changes from dledda-r7 and h00die's review on rapid7#21128 (Nayeraneru's win-port-monitor branch): - Removed the DefaultOptions block disabling the payload handler and hardcoding a meterpreter/reverse_tcp payload; persistence modules need the handler active to catch the callback when the payload fires later. - Dropped ARCH_AARCH64 from Arch, since Metasploit has no meterpreter or shell payload for that architecture yet. - Restricted SessionTypes to meterpreter only. - DLL_NAME no longer fails validation when missing a .dll extension; payload_name now appends it automatically. - MONITOR_NAME and DLL_NAME now default to randomized 8-character alpha strings instead of static "Hadess"/"persist.dll" values, and are marked required to match. - Documentation: restructured Scenarios headings (### OS / #### scenario per h00die's convention), removed the unrelated local_exploit_suggester detour, fixed an escaped   entity and a doubled backslash in a code span, and updated the Options section for the new randomized defaults. Passes tools/dev/msftidy_docs.rb clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ae2LTwjw9tvJqqGqqwjerz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the requested changes from dledda-r7 and h00die's review on rapid7#21128 (Nayeraneru's win-port-monitor branch):
Claude-Session: https://claude.ai/code/session_01Ae2LTwjw9tvJqqGqqwjerz
Thank you for contributing to Metasploit Framework! Your time and effort help make this project better for the entire security community. If you have questions at any point, reach out on GitHub Discussions or the Metasploit Slack.
Description
Related Issue:
Breaking Changes
None
Reviewer Notes
Verification Steps
Test Evidence
Environment
AI Usage Disclosure
Pre-Submission Checklist
documentation/modules(new modules only)lib/changes)Hardware and Complex Software Module Guidance
If your module targets specialized hardware (routers, IoT, PLCs, etc.) or complex software (licensed, multi-service, or multi-version), provide a pcap, screen recording, or video showing successful execution.
Email sanitized pcaps/recordings to msfdev@metasploit.com — remove real IPs, credentials, and hostnames before sending. If hardware/software is unavailable, explain in the PR description.
Responsiveness and PR Takeover Policy
We want every contribution to make it into the project. If approximately 2 weeks pass after a review request without a comment or code update from you, the team may take over the PR and complete the work on your behalf.
If this happens, you will remain credited as a co-author on the final commit — your contribution is always recognized.
This policy exists to keep the project moving forward. It is not a reflection on the quality of your work or your involvement. Life happens, and we would rather finish the work together than let a good contribution go stale.