Sprint Sections 17 Stage 2 Requests - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
PR goal: implement user participation requests (create/list/cancel), refine event update/lookup flows, adjust DTOs/mappers, and tidy configuration/logging.
- Add private endpoints for participation requests and implement service/repository logic.
- Refactor event service/mappers (category handling, confirmed requests as int), and adjust validation annotations on controllers/DTOs.
- Replace several date annotations; add logging and minor property file comments.
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| stats/stats-server/src/main/resources/application.properties | Add section comments; no functional changes. |
| stats/stats-server/src/main/resources/application-test.properties | Add section comments; no functional changes. |
| stats/stats-server/src/main/resources/application-local.properties | Add section comments; no functional changes. |
| stats/stats-server/src/main/java/ru/practicum/controller/StatsController.java | Logging level tweaks. |
| stats/stats-dto/src/main/java/ru/practicum/CreateEndpointHitDto.java | Replace Jackson JsonFormat with Spring DateTimeFormat on request body timestamp. |
| main-service/src/main/resources/schema.sql | Minor casing changes in CREATE statements. |
| main-service/src/main/resources/application.properties | Add section comments; no functional changes. |
| main-service/src/main/resources/application-test.properties | Add section comments; no functional changes. |
| main-service/src/main/resources/application-local.properties | Add section comments; no functional changes. |
| main-service/src/main/java/ru/practicum/user/service/UserServiceImpl.java | Adjust log message content. |
| main-service/src/main/java/ru/practicum/user/model/User.java | Add @tostring. |
| main-service/src/main/java/ru/practicum/user/controller/AdminUserController.java | Add validation annotations to params and path variables. |
| main-service/src/main/java/ru/practicum/request/service/RequestServiceImpl.java | Implement add/list/cancel requests; refactor update logic; new validations/logging. |
| main-service/src/main/java/ru/practicum/request/service/RequestService.java | Add methods for request operations. |
| main-service/src/main/java/ru/practicum/request/repository/RequestRepository.java | Add projection query for user requests and existence check; rename count query. |
| main-service/src/main/java/ru/practicum/request/model/Request.java | Make relations LAZY; add @CreationTimestamp and canceled() state. |
| main-service/src/main/java/ru/practicum/request/mapper/RequestMapper.java | Add toEntity(Event, User, RequestStatus) and adjust mappings. |
| main-service/src/main/java/ru/practicum/request/controller/RequestController.java | Remove empty placeholder controller. |
| main-service/src/main/java/ru/practicum/request/controller/PrivateRequestController.java | New endpoints: list/add/cancel participation requests per user. |
| main-service/src/main/java/ru/practicum/event/service/EventServiceImpl.java | Refactor get/update event (category handling, int counts); change authorization lookups; tweak exceptions/logging. |
| main-service/src/main/java/ru/practicum/event/service/EventService.java | Change signature getEventOrThrow(Long). |
| main-service/src/main/java/ru/practicum/event/repository/EventRepository.java | Remove findByIdAndInitiatorId; minor imports reorder. |
| main-service/src/main/java/ru/practicum/event/model/EventWithCountConfirmedRequests.java | Store count as int; add converting constructor. |
| main-service/src/main/java/ru/practicum/event/model/Event.java | Remove default true initializer for requestModeration. |
| main-service/src/main/java/ru/practicum/event/mapper/EventMapper.java | Consolidate MapStruct imports; use category in mappings; null-value ignore; int counts. |
| main-service/src/main/java/ru/practicum/event/dto/UpdateEventUserRequest.java | Switch paid/requestModeration to Boolean. |
| main-service/src/main/java/ru/practicum/event/dto/UpdateEventAdminRequest.java | Switch paid/requestModeration to Boolean. |
| main-service/src/main/java/ru/practicum/event/dto/SearchEventPublicRequest.java | Use DateTimeFormat for query params; defaults in compact ctor. |
| main-service/src/main/java/ru/practicum/event/dto/SearchEventAdminRequest.java | Use DateTimeFormat for query params. |
| main-service/src/main/java/ru/practicum/event/dto/NewEventDto.java | Switch to nullable Booleans; default values in compact ctor. |
| main-service/src/main/java/ru/practicum/event/dto/EventFullDto.java | Switch paid/requestModeration to Boolean. |
| main-service/src/main/java/ru/practicum/event/controller/PublicEventController.java | Add @positive to path variable. |
| main-service/src/main/java/ru/practicum/event/controller/PrivateEventController.java | Rebase routes to /users/{userId}/events; add validation. |
| main-service/src/main/java/ru/practicum/event/controller/AdminEventController.java | Add @positive; tweak logs. |
| main-service/src/main/java/ru/practicum/category/service/CategoryServiceImpl.java | Expose getCategoryByIdOrThrow; minor logs. |
| main-service/src/main/java/ru/practicum/category/service/CategoryService.java | Add getCategoryByIdOrThrow to interface. |
| main-service/src/main/java/ru/practicum/category/model/Category.java | Add @tostring. |
| main-service/src/main/java/ru/practicum/category/controller/PublicCategoryController.java | Add @positive to path variable. |
| main-service/src/main/java/ru/practicum/category/controller/AdminCategoryController.java | Add @positive; tweak logs. |
| .github/copilot-instructions.md | Minor wording punctuation. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Naz1anmak
force-pushed
the
main_svc_requests
branch
3 times, most recently
from
October 17, 2025 16:46
4943935 to
72bf100
Compare
…ation properties for improved configuration
Naz1anmak
force-pushed
the
main_svc_requests
branch
from
October 17, 2025 16:59
72bf100 to
22be17e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.