Skip to content

Sprint Sections 17 Stage 2 Requests - #10

Merged
internet-prodashi merged 1 commit into
main_svcfrom
main_svc_requests
Oct 17, 2025
Merged

Sprint Sections 17 Stage 2 Requests#10
internet-prodashi merged 1 commit into
main_svcfrom
main_svc_requests

Conversation

@Naz1anmak

Copy link
Copy Markdown
Owner

No description provided.

@Naz1anmak
Naz1anmak requested a review from Copilot October 17, 2025 13:23
@Naz1anmak Naz1anmak self-assigned this Oct 17, 2025
@Naz1anmak Naz1anmak added the enhancement New feature or request label Oct 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

PR goal: implement user participation requests (create/list/cancel), refine event update/lookup flows, adjust DTOs/mappers, and tidy configuration/logging.

  • Add private endpoints for participation requests and implement service/repository logic.
  • Refactor event service/mappers (category handling, confirmed requests as int), and adjust validation annotations on controllers/DTOs.
  • Replace several date annotations; add logging and minor property file comments.

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
stats/stats-server/src/main/resources/application.properties Add section comments; no functional changes.
stats/stats-server/src/main/resources/application-test.properties Add section comments; no functional changes.
stats/stats-server/src/main/resources/application-local.properties Add section comments; no functional changes.
stats/stats-server/src/main/java/ru/practicum/controller/StatsController.java Logging level tweaks.
stats/stats-dto/src/main/java/ru/practicum/CreateEndpointHitDto.java Replace Jackson JsonFormat with Spring DateTimeFormat on request body timestamp.
main-service/src/main/resources/schema.sql Minor casing changes in CREATE statements.
main-service/src/main/resources/application.properties Add section comments; no functional changes.
main-service/src/main/resources/application-test.properties Add section comments; no functional changes.
main-service/src/main/resources/application-local.properties Add section comments; no functional changes.
main-service/src/main/java/ru/practicum/user/service/UserServiceImpl.java Adjust log message content.
main-service/src/main/java/ru/practicum/user/model/User.java Add @tostring.
main-service/src/main/java/ru/practicum/user/controller/AdminUserController.java Add validation annotations to params and path variables.
main-service/src/main/java/ru/practicum/request/service/RequestServiceImpl.java Implement add/list/cancel requests; refactor update logic; new validations/logging.
main-service/src/main/java/ru/practicum/request/service/RequestService.java Add methods for request operations.
main-service/src/main/java/ru/practicum/request/repository/RequestRepository.java Add projection query for user requests and existence check; rename count query.
main-service/src/main/java/ru/practicum/request/model/Request.java Make relations LAZY; add @CreationTimestamp and canceled() state.
main-service/src/main/java/ru/practicum/request/mapper/RequestMapper.java Add toEntity(Event, User, RequestStatus) and adjust mappings.
main-service/src/main/java/ru/practicum/request/controller/RequestController.java Remove empty placeholder controller.
main-service/src/main/java/ru/practicum/request/controller/PrivateRequestController.java New endpoints: list/add/cancel participation requests per user.
main-service/src/main/java/ru/practicum/event/service/EventServiceImpl.java Refactor get/update event (category handling, int counts); change authorization lookups; tweak exceptions/logging.
main-service/src/main/java/ru/practicum/event/service/EventService.java Change signature getEventOrThrow(Long).
main-service/src/main/java/ru/practicum/event/repository/EventRepository.java Remove findByIdAndInitiatorId; minor imports reorder.
main-service/src/main/java/ru/practicum/event/model/EventWithCountConfirmedRequests.java Store count as int; add converting constructor.
main-service/src/main/java/ru/practicum/event/model/Event.java Remove default true initializer for requestModeration.
main-service/src/main/java/ru/practicum/event/mapper/EventMapper.java Consolidate MapStruct imports; use category in mappings; null-value ignore; int counts.
main-service/src/main/java/ru/practicum/event/dto/UpdateEventUserRequest.java Switch paid/requestModeration to Boolean.
main-service/src/main/java/ru/practicum/event/dto/UpdateEventAdminRequest.java Switch paid/requestModeration to Boolean.
main-service/src/main/java/ru/practicum/event/dto/SearchEventPublicRequest.java Use DateTimeFormat for query params; defaults in compact ctor.
main-service/src/main/java/ru/practicum/event/dto/SearchEventAdminRequest.java Use DateTimeFormat for query params.
main-service/src/main/java/ru/practicum/event/dto/NewEventDto.java Switch to nullable Booleans; default values in compact ctor.
main-service/src/main/java/ru/practicum/event/dto/EventFullDto.java Switch paid/requestModeration to Boolean.
main-service/src/main/java/ru/practicum/event/controller/PublicEventController.java Add @positive to path variable.
main-service/src/main/java/ru/practicum/event/controller/PrivateEventController.java Rebase routes to /users/{userId}/events; add validation.
main-service/src/main/java/ru/practicum/event/controller/AdminEventController.java Add @positive; tweak logs.
main-service/src/main/java/ru/practicum/category/service/CategoryServiceImpl.java Expose getCategoryByIdOrThrow; minor logs.
main-service/src/main/java/ru/practicum/category/service/CategoryService.java Add getCategoryByIdOrThrow to interface.
main-service/src/main/java/ru/practicum/category/model/Category.java Add @tostring.
main-service/src/main/java/ru/practicum/category/controller/PublicCategoryController.java Add @positive to path variable.
main-service/src/main/java/ru/practicum/category/controller/AdminCategoryController.java Add @positive; tweak logs.
.github/copilot-instructions.md Minor wording punctuation.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread main-service/src/main/java/ru/practicum/request/service/RequestServiceImpl.java Outdated
Comment thread main-service/src/main/java/ru/practicum/request/service/RequestServiceImpl.java Outdated
Comment thread main-service/src/main/java/ru/practicum/request/repository/RequestRepository.java Outdated
Comment thread main-service/src/main/java/ru/practicum/request/service/RequestServiceImpl.java Outdated
@Naz1anmak
Naz1anmak force-pushed the main_svc_requests branch 3 times, most recently from 4943935 to 72bf100 Compare October 17, 2025 16:46
@internet-prodashi
internet-prodashi merged commit a9fbde9 into main_svc Oct 17, 2025
1 of 2 checks passed
@Naz1anmak
Naz1anmak deleted the main_svc_requests branch October 17, 2025 19:27
@Naz1anmak Naz1anmak added this to the Sprint 17 Stage 2 milestone Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants