Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Added periodic task scheduling for iOS in Workmanager#53

Open
burhanaksendir wants to merge 4 commits into
NedaaDevs:masterfrom
burhanaksendir:master
Open

Added periodic task scheduling for iOS in Workmanager#53
burhanaksendir wants to merge 4 commits into
NedaaDevs:masterfrom
burhanaksendir:master

Conversation

@burhanaksendir

Copy link
Copy Markdown

No description provided.

Include workmanager to use WorkmanagerPlugin.registerPeriodicTask
Set up registerPeriodicTask to run every 2 days on iOS as on Android"
Refactor callbackDispatcher to handle the same task for both Android and iOS
@F2had F2had requested review from Amjad50 and F2had June 21, 2024 17:22
@F2had

F2had commented Jun 21, 2024

Copy link
Copy Markdown
Member

@burhanaksendir
Would you please run dart format . & flutter analyze for the CI to continue

@burhanaksendir

Copy link
Copy Markdown
Author

@burhanaksendir Would you please run dart format . & flutter analyze for the CI to continue

I have run dart format . and flutter analyze, and updated the main.dart file accordingly.

@Amjad50

Amjad50 commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

Hello @burhanaksendir , this is an interesting change, so looks like workmanager library added functionality to support ios background tasks.

Though, I do not prefer using the git version of the library, is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?

@burhanaksendir

Copy link
Copy Markdown
Author

Hello @burhanaksendir , this is an interesting change, so looks like workmanager library added functionality to support ios background tasks.

Though, I do not prefer using the git version of the library, is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?

Hello @Amjad50,
the reason I am using the git version is because it supports periodic tasks for iOS. In the normal version, only the registerOneOffTask feature is available for iOS. However, with this git version, we can run background tasks periodically on iOS just like we do on Android.

@Amjad50

Amjad50 commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

I understand the benefit and I like it.

My question was "is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?"

But, I guess we can merge this now, and change the version once they release it.

@F2had

F2had commented Jun 22, 2024

Copy link
Copy Markdown
Member

@burhanaksendir
Sorry can you add the latest changes on the master to your pr.
I made some fixes on the CI

@F2had F2had removed their request for review June 22, 2024 18:00
@F2had F2had added the enhancement New feature or request label Jun 22, 2024
@F2had F2had enabled auto-merge June 22, 2024 18:05
@F2had F2had linked an issue Jun 22, 2024 that may be closed by this pull request
@burhanaksendir

Copy link
Copy Markdown
Author

I understand the benefit and I like it.

My question was "is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?"

But, I guess we can merge this now, and change the version once they release it.

Yes, we can request a new version to be released. I don't know why a new version hasn't been released, but you can check the commit details here. Unfortunately, I could only run the periodic task for iOS with this ref.
fluttercommunity/flutter_workmanager@b783000

@burhanaksendir burhanaksendir left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have added the latest changes from the master branch to my PR. Please review it again. Thank you!

@F2had

F2had commented Jun 23, 2024

Copy link
Copy Markdown
Member

Hi, I have added the latest changes from the master branch to my PR. Please review it again. Thank you!

Just checked it doesn’t seems like your pr is up to date with master. Can you please double check

@F2had F2had disabled auto-merge October 19, 2024 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with WorkManager for Local Notifications on iOS

3 participants