feature: Adds a unitless percent unit
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
bjschoenfeld
approved these changes
Sep 9, 2024
NeedleInAJayStack
requested changes
Sep 9, 2024
Owner
NeedleInAJayStack
left a comment
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Thanks Jairon! Glad to see it #justworks
| ) | ||
| } | ||
|
|
||
| func testPercent() throws { |
Owner
There was a problem hiding this comment.
Please add an additional test in the DefinitionsTests.swift and copy the formatting there.
Owner
There was a problem hiding this comment.
Whoops - my bad. I meant DefinitionTests.swift:
https://github.com/NeedleInAJayStack/Units/blob/main/Tests/UnitsTests/DefinitionTests.swift
CrownedPhoenix
force-pushed
the
feature/percent-unit
branch
from
de8256c to
21f7aa4
Compare
CrownedPhoenix
force-pushed
the
feature/percent-unit
branch
from
21f7aa4 to
858247b
Compare
NeedleInAJayStack
requested changes
Jun 3, 2025
| try { | ||
| let percent1 = 5.measured(in: .percent) | ||
| let value2 = 5.measured(in: .none) | ||
| XCTAssertThrowsError(try percent1 + value2) |
Owner
There was a problem hiding this comment.
Ah, looks like this test is failing in CI because this no longer throws an error. I've added cross-unit addition/subtraction support since this MR was opened, so this will succeed and result in 505%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
percentunit type.Some review will be needed to make sure I've tested everything worth testing in this regard.
So far, everything seems to 'just work'.