Fix remaining image and URL parser denial-of-service paths - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed image headers can hang Metro, and malicious encoded URL input can exhaust CPU in the Expo Router dependency chain. This change guards ICNS/BMFF parser progress and upgrades the decoder to 0.5.0 with the CommonJS import adaptation query-string needs. A further decoder patch processes distinct encoded runs once, eliminating the remaining repeated-rescan fallback.
The three version-specific patches apply during npm postinstall with errors treated as failures. CI performs a clean install and runs the security regression suite. Package identities and published versions are preserved.
Validation:
Dependabot status: the decoder upgrade should close its alert. The two image-size alerts may remain because scanners see upstream 1.2.1, not the locally applied guards, and upstream has no published fixed release. These alerts are intentionally not dismissed. npm audit currently reports image-size and its transitive Metro parents only. Patch rationale and removal guidance are documented under patches/.