Conversation
added 7 commits
November 6, 2018 11:02
- used modulizer - manual tweaking and correct imports - 1 out of 2 demos working
…empty label is set
Owner
|
Thank you for the PR ! |
Author
|
Yes, I'll take a look at it and by the way,the last two changes shouldn't have gone to this branch. I think we need to revert them and maybe open another issue because I had problems with the clicking/taping behavior (sometimes menu disappears, but item is not selected) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ported the autocomplete components to Polymer 3.0 with almost no changes to the logic. I used
the class based declaration even though a
Polymer(...)declaration would have been possible by using legacy methods, the new method is more concise and can be transpiled to ES5 during the build process.