Repository navigation
Attach the installers from where they are downloaded - #42
Merged
Merged
Conversation
download-artifact@v8 puts a single artifact matched by `pattern` straight into `path`, so the MSIs were in msi/, not msi/msi-x64/, and the attestation found nothing at msi/*/*.msi: the run for v0.3.0 built and tested both installers, then attached neither. The attach job now downloads each artifact by name, as the test job does, and takes msi/*.msi. The job runs only for a release or by hand, so no pull request exercises it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nelsar
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.0 release has no installers attached. The Installers run built both MSIs and installed, upgraded and removed the x64 one, then the attach job stopped at the attestation:
download-artifact@v8extracts a single artifact matched bypatternstraight intopath: the log saysStarting download of artifact to: …/msi, not…/msi/msi-x64. The attach job now downloads each artifact byname, as the test job already does, and attests and uploadsmsi/*.msi.The attach job is skipped on pull requests, so the checks here do not exercise it.
After merging
Run
Installersby hand frommainfor the existing release:It builds from the
v0.3.0tag, attaches both MSIs with their attestation, and adds the Windows installers section to the notes. That edit is also what makes SourceForge copy them. This is the recovery CONTRIBUTING's Releasing describes. The attestation will namemainas the workflow's ref, since that is where it runs from;gh attestation verify <file> --repo Nelsar/Axiapasses either way.