Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2347 +/- ##
==========================================
- Coverage 88.23% 87.94% -0.30%
==========================================
Files 126 126
Lines 32000 32173 +173
==========================================
+ Hits 28234 28293 +59
- Misses 3766 3880 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generic.spoly for computing the S-polynomial of two Generic.MPoly
Member
|
Needs a test case or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractAlgebra.Generic.spoly(f, g, 2, 3) implements the spoly of f and g, assuming the leading term of f is at position 2 and for g is at position 3.
if not given, it uses the last term (position length), which should tbe the term
Mainly for @lkastner to play with the MPolyQQBar. It traverses the polynomials once and does all the exponents as inplace as possible - I hope