chore(deps): lucide-svelte 1.0, keeping the brand icons locally - #24
Merged
Conversation
v1 removes the brand icons — a trademark decision upstream, not an oversight, so they are not coming back. The GitHub and LinkedIn marks now live in the repo as two small components carrying lucide's own geometry verbatim, ISC attribution in the header comment. Kept as outlines rather than the filled marks the brands publish: every other icon in the header is a 24x24 lucide outline, and a filled logo beside them reads as a mismatch. Same viewBox, stroke width and caps as their neighbours. The import names are unchanged, so nothing at the call sites moved. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lucide-svelte v1 removes the brand icons. That's a trademark decision upstream, not an oversight, so they aren't coming back and the bump can't land as a version change alone: the build fails with
Module 'lucide-svelte' has no exported member 'Github'.The GitHub and LinkedIn marks now live in the repo as two small components carrying lucide's own geometry verbatim, with ISC attribution in the header comment.
They're kept as outlines rather than the filled marks the brands publish. Every other icon in the header is a 24×24 lucide outline, and a filled logo beside them reads as a mismatch — same viewBox, stroke width and caps as their neighbours. Verified rendering in the header and the About modal.
Import names are unchanged, so no call site moved.
Supersedes #17.
492 unit, 67 e2e, lint, type-check and build clean.
🤖 Generated with Claude Code