Skip to content

Skip module installation when any dependency spec is configured#190

Merged
NeonDaniel merged 1 commit into
devfrom
FIX_PreventInstallingInvalidModule
Sep 12, 2025
Merged

Skip module installation when any dependency spec is configured#190
NeonDaniel merged 1 commit into
devfrom
FIX_PreventInstallingInvalidModule

Conversation

@NeonDaniel
Copy link
Copy Markdown
Member

@NeonDaniel NeonDaniel commented Sep 12, 2025

Description

Mark backwards-compat package installation as deprecated
Prevent installation of module when any other specific dependency is specified

Issues

Other Notes

  • Pushed image ghcr.io/neongeckocom/neon_audio:alpha with these changes
  • This is potentially a breaking change, though it should be very uncommon that someone intentionally specifies audio extra dependencies that don't include the package required for the configured module

Copy link
Copy Markdown
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue I had in my Hub

Prevent installation of `module` when any other specific dependency is
specified
@NeonDaniel NeonDaniel force-pushed the FIX_PreventInstallingInvalidModule branch from a9edd09 to bbe3419 Compare September 12, 2025 19:42
@NeonDaniel NeonDaniel merged commit c9c6cd1 into dev Sep 12, 2025
8 checks passed
@NeonDaniel NeonDaniel deleted the FIX_PreventInstallingInvalidModule branch September 12, 2025 21:22
@github-actions github-actions Bot mentioned this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants