Skip to content

feat: intent for "wake me"#145

Open
mikejgray wants to merge 4 commits into
devfrom
FEAT_WakeMeIntent
Open

feat: intent for "wake me"#145
mikejgray wants to merge 4 commits into
devfrom
FEAT_WakeMeIntent

Conversation

@mikejgray
Copy link
Copy Markdown

Description

Adds support for "wake me" style intents for alarms.

Issues

Closes #119

Other Notes

I had some odd test results locally on my Macbook, hoping CI will be more forgiving

Comment thread requirements.txt
Comment thread test/test_intents.yaml
Comment thread test/test_skill.py
def test_wake_me_intent(self):
from skill_alerts.util.parse_utils import build_alert_from_intent
sea_tz = gettz("America/Los_Angeles")
wake_me_up = _get_message_from_file("wake_me_up_at_time_alarm.json")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test file

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't missing in my local repo. Where are you seeing it missing?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Support "wake me up" to set an alarm

2 participants