Skip to content

Ukrainian translation#148

Merged
NeonDaniel merged 16 commits into
NeonGeckoCom:devfrom
NeonDmitry:ua_translation
Nov 17, 2025
Merged

Ukrainian translation#148
NeonDaniel merged 16 commits into
NeonGeckoCom:devfrom
NeonDmitry:ua_translation

Conversation

@NeonDmitry
Copy link
Copy Markdown
Contributor

@NeonDmitry NeonDmitry commented Jul 1, 2025

Description

Include Ukrainian translation with intent and resource tests

Issues

Other Notes

Disables OVOS intent tests to work around dependency error to be fixed in shared automation

@NeonDmitry NeonDmitry requested a review from NeonDaniel July 1, 2025 18:04
@NeonDaniel NeonDaniel changed the title Ua translation Ukrainian translation Jul 3, 2025
Copy link
Copy Markdown
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a little more intent test coverage; we at least should test the basic functionality of alert creation (listing alerts already implemented in intent tests)

Comment thread test/test_intents.yaml
added  test cases for "CreateAlarm", "CreateTimer", and "CreateReminder"
@NeonDaniel
Copy link
Copy Markdown
Member

Based on dev branch failure, I think neon-minerva dependency just needs updating here to add >=0.3.1a2

Comment thread .github/workflows/skill_tests.yml Outdated
Comment thread test/test_intents.yaml Outdated
Comment thread test/test_intents.yaml
@NeonDaniel NeonDaniel merged commit 9c25ab2 into NeonGeckoCom:dev Nov 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants