fix: Add login functionality to editor upload dialog - #16
Merged
Merged
Conversation
Previously, when users tried to upload from the editor to the server, they would see a "not authenticated" error even after logging into the editor. This was because there are two separate authentication systems: 1. Packet-based authentication for editor-to-game-server connection 2. HTTP token authentication for web API endpoints (updates/uploads) The upload functionality requires HTTP token authentication, but users who logged in normally through the editor only had packet-based auth. Changes made: - Added a "Login" button to the upload form that appears when not authenticated - Implemented btnLogin_Click handler that prompts for credentials - Added authentication via IntersectHttpClient.TryRequestToken() - Token is saved to preferences for future sessions - Credentials are hashed and saved for convenience - Updated authentication status display to guide users to click Login This allows users to authenticate directly from the upload dialog without needing to go through the editor update flow first. Fixes authentication issues when uploading from editor to server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when users tried to upload from the editor to the server, they would see a "not authenticated" error even after logging into the editor. This was because there are two separate authentication systems:
The upload functionality requires HTTP token authentication, but users who logged in normally through the editor only had packet-based auth.
Changes made:
This allows users to authenticate directly from the upload dialog without needing to go through the editor update flow first.
Fixes authentication issues when uploading from editor to server.