fix: Improve upload authentication and add file filtering - #17
Merged
Merged
Conversation
This commit addresses two major issues with the upload functionality: 1. Login Button Visibility & Token Validation: - Added JWT token expiration checking to detect expired tokens - Clear expired/invalid tokens and show login button when needed - Force UI refresh after updating authentication status - Handle 401 errors by clearing token and showing login button - Improved error messages for authentication failures 2. File Filtering Like Package Update: - Added comprehensive file exclusion logic matching package update - Exclude DLLs, XML files, configs, logs, screenshots - Type-specific exclusions for client vs editor uploads - Handle asset packs properly (exclude packed sources for client) - Process .meta files to identify packed assets - Support for sound and music pack exclusions The upload now behaves consistently with package update, filtering out unnecessary files and properly handling authentication state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two major issues with the upload functionality:
Login Button Visibility & Token Validation:
File Filtering Like Package Update:
The upload now behaves consistently with package update, filtering out unnecessary files and properly handling authentication state.