fix: submit inputs on Enter without double-trigger#442
Closed
shields wants to merge 4 commits intoNerivec:mainfrom
Closed
fix: submit inputs on Enter without double-trigger#442shields wants to merge 4 commits intoNerivec:mainfrom
shields wants to merge 4 commits intoNerivec:mainfrom
Conversation
Previously, RangeEditor and TextEditor only submitted values on blur (clicking outside). Add onKeyDown handlers so pressing Enter also triggers the onChange callback.
Owner
|
Unless I'm mistaken, this will double-trigger with |
Track last submitted value with useTrackedValue hook so onChange is only called when the value actually changed. Prevents double-trigger when Enter is followed by blur, and skips unnecessary blur submissions when the value hasn't changed.
shields
changed the title
Author
Good catch. There's a related bug in the current code in that if you focus and blur the field, it will submit unnecessarily. Fixed both issues. |
Owner
Been meaning to fix that one indeed 😁 |
Contributor
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
onKeyDownhandlers toRangeEditorandTextEditorso pressing Enter triggersonChange. Track the last submitted value via auseTrackedValuehook to prevent double-trigger on Enter+blur and skip unnecessary blur submissions when the value hasn't changed.