Conversation
Co-authored-by: NeroAgent <NeroAgent@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Issue: #XXXX
Description
This PR introduces a new
app/module, implementing the "Hermes Lite" Android vision system. This module provides a floating overlay avatar for interactive screen analysis, leveraging MediaProjection for screen capture and aHermesBridgefor communication.Key features include:
HermesBridgefor MessagePack communication over Unix sockets to Termux, with WebSocket fallback and robust reconnection logic.EncryptedSharedPreferences.FOREGROUND_SERVICE_SPECIAL_USE,FOREGROUND_SERVICE_MEDIA_PROJECTION) and memory/battery optimization strategies.The module is designed to be stateless, with zero local inference, acting purely as a relay/bridge.
Test Procedure
Due to environment limitations, a full Gradle build was not executed. However, the following checks were performed:
build.gradledependencies and SDK configurations.AndroidManifest.xmlfor correct permissions, service declarations, and Android 14 foreground service attributes.Confidence is based on a thorough review of the generated code against all specified requirements and Android best practices.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
N/A - This PR introduces the foundational Android module and services; no specific UI screenshots are provided at this stage.
Additional Notes
A full Gradle build was not possible in the development environment. Therefore, compilation and runtime validation will need to be performed by reviewers.