Skip to content

fix: secret handling in PrepareOldCred #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchekalov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: secret handling in PrepareOldCred #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions pkg/hook/credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,29 @@ func PrepareOldCreds(secrets []string) {
if err != nil {
panic(err)
}
oldSecret := oldSecret(oldSecretName)
oldSecret.Data = newSecret.Data
oldSecret.Labels = newSecret.Labels
if !isSecretExist {
oldSecret := oldSecret(oldSecretName)
oldSecret.Data = newSecret.Data
oldSecret.Labels = newSecret.Labels
err = k8sClient.Create(ctx, oldSecret)
if err != nil {
logger.Info(fmt.Sprintf("cannot create %s secret", oldSecret.Name))
panic(err)
}
} else {
err = k8sClient.Update(ctx, oldSecret)
existingOldSecret := &corev1.Secret{}
err = k8sClient.Get(ctx, types.NamespacedName{
Name: oldSecretName, Namespace: namespace,
}, existingOldSecret)
if err != nil {
logger.Info(fmt.Sprintf("cannot update %s secret", oldSecret.Name))
logger.Info(fmt.Sprintf("cannot get existing %s secret", oldSecretName))
panic(err)
}
existingOldSecret.Data = newSecret.Data
existingOldSecret.Labels = newSecret.Labels
err = k8sClient.Update(ctx, existingOldSecret)
if err != nil {
logger.Info(fmt.Sprintf("cannot update %s secret", existingOldSecret.Name))
panic(err)
}
}
Expand Down
Loading