feat: #811 Add tracebility comments in Effective Set#1087
Closed
KamalArya wants to merge 11 commits into
Closed
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
KamalArya
force-pushed
the
feature/es-trace
branch
13 times, most recently
from
634b5a0 to
7e448ab
Compare
KamalArya
force-pushed
the
feature/es-trace
branch
4 times, most recently
from
60a1af9 to
70850a6
Compare
KamalArya
force-pushed
the
feature/es-trace
branch
6 times, most recently
from
effb04e to
5242bbb
Compare
KamalArya
force-pushed
the
feature/es-trace
branch
3 times, most recently
from
2f1619e to
860f856
Compare
KamalArya
force-pushed
the
feature/es-trace
branch
15 times, most recently
from
1f88f0d to
1f7a925
Compare
KamalArya
force-pushed
the
feature/es-trace
branch
from
b2ab5f6 to
184f6ae
Compare
Collaborator
Author
|
created new PR #1317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Provide a concise description of what this pull request does and why it is needed.
Issue
Link to the issue(s) this PR addresses (e.g.,
Fixes #123orCloses #456). If no issue exists, explain why this change is necessary.Breaking Change?
If yes, describe the breaking change and its impact (e.g., API changes, behavior changes, or required updates for users).
Scope / Project
Specify the component, module, or project area affected by this change (e.g.,
docs,actions,workflows).Implementation Notes
Switched to SnakeYAML Engine instead of the classic SnakeYAML library to enable comment support in YAML nodes.
The Parameter object passed during YAML dumping is unwrapped, and origin details are added as comments based on conditions.
Implemented custom anchor node creation to support anchors and aliases.
Added a separate mechanism to disable YAML anchors in cases of excessive aliasing. This uses SnakeYAML Engine along with a HashMap to track node counts (instead of IdentityHashMap).
Tests / Evidence
Describe how the changes were verified, including:
Additional Notes
This change is aimed at adding traceability support in the effective set:
Issue: #811
Documentation: https://github.com/Netcracker/qubership-envgene/blob/main/docs/features/calculator-cli.md#version-20-traceability-comments
Approach:
Switched to SnakeYAML Engine instead of the classic SnakeYAML library to enable comment support in YAML nodes.
The Parameter object passed during YAML dumping is unwrapped, and origin details are added as comments based on conditions.
Implemented custom anchor node creation to support anchors and aliases.
Added a separate mechanism to disable YAML anchors in cases of excessive aliasing. This uses SnakeYAML Engine along with a HashMap to track node counts (instead of IdentityHashMap).