feat: add resource migration job and troubleshooting section for upgrade failures#289
feat: add resource migration job and troubleshooting section for upgrade failures#289mrMigles wants to merge 3 commits into
Conversation
…ade failures Introduced a new resource migration job to handle OpenSearch StatefulSets during upgrades, along with a troubleshooting section in the documentation addressing potential upgrade failures due to pre-deploy migration hooks. This includes detailed descriptions, stack traces, solutions, and recommendations for successful upgrades.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bd3c87855
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…arch upgrades Introduced a new section detailing the resource migration job that automatically handles the removal of incompatible OpenSearch 1.x StatefulSets during upgrades to 2.x. This section explains the job's functionality, parameters, and how it integrates with ArgoCD to ensure a smooth upgrade process without manual intervention.
github-actions
Bot
added
the
documentation
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # docs/public/troubleshooting.md Co-authored-by: PhBouzid <15084032+PhBouzid@users.noreply.github.com>
Resolved the merge conflicts in commit |
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
| | `integrationTests.securityContext` | object | no | {} | The pod-level security attributes and common container settings for the OpenSearch integration tests pod. | | ||
| | `integrationTests.priorityClassName` | string | no | "" | The priority class to be used by the OpenSearch integration tests pods. You should create the priority class beforehand. For more information about this feature, refer to [https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/](https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/). | | ||
|
|
||
| ## Resource Migration |
There was a problem hiding this comment.
New chapters are not added to the TOC
| | `integrationTests.securityContext` | object | no | {} | The pod-level security attributes and common container settings for the OpenSearch integration tests pod. | | ||
| | `integrationTests.priorityClassName` | string | no | "" | The priority class to be used by the OpenSearch integration tests pods. You should create the priority class beforehand. For more information about this feature, refer to [https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/](https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/). | | ||
|
|
||
| ## Resource Migration |
There was a problem hiding this comment.
Please, move this section after Tags Description of integration tests.
| {{- if .Values.resourceMigration.runAsNonRoot }} | ||
| securityContext: | ||
| runAsNonRoot: true | ||
| seccompProfile: { type: RuntimeDefault } |
There was a problem hiding this comment.
Maybe just
seccompProfile:
type: RuntimeDefault
?
|
|
||
| # 'node.master' env is a marker of OpenSearch 1.x StatefulSets that must be | ||
| # recreated during upgrade to 2.x because ArgoCD merge cannot remove extra envs. | ||
| NODE_MASTER="$(printf '%s' "$STS_JSON" \ |
There was a problem hiding this comment.
Can we use just echo "$STS_JSON" instead of printf '%s' "$STS_JSON"?
Introduced a new resource migration job to handle OpenSearch StatefulSets during upgrades, along with a troubleshooting section in the documentation addressing potential upgrade failures due to pre-deploy migration hooks. This includes detailed descriptions, stack traces, solutions, and recommendations for successful upgrades.
What type of PR is this? (check all applicable)
Description
TDB
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Breaking Change checklist
If your PR includes any deployment or processing changes, please utilize this checklist:
Added/updated tests?
have not been included
[optional] Are there any things to highlight or double check?
[optional] What gif best describes this PR or how it makes you feel?