Skip to content

bug: #9 Bruno job can't unpack ATP tests archive #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dale1020 merged 7 commits into from
Mar 12, 2026
Merged

bug: #9 Bruno job can't unpack ATP tests archive #8

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4d10b1
create git_clone_logging branch
dale1020 Feb 9, 2026
a740032
feat: added git clone logging in case if token/url incorrect (#2)
callmesi Feb 9, 2026
d20a77b
feat:telemetry otel and trace-id generation logic (#3)
callmesi Feb 11, 2026
91e0df6
Feat/telemetry (#4)
callmesi Feb 12, 2026
28ba390
Feat/telemetry (#5)
callmesi Feb 12, 2026
cc36769
Feat/telemetry (#6)
callmesi Feb 12, 2026
a6ec71f
feat:git clone logging remove not used files
callmesi Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 171 additions & 6 deletions git-clone.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,186 @@ clone_repository() {
else
echo "📥 Cloning tests repository..."

# ============================================
# Pre-flight validation
# ============================================
if [ -z "${ATP_TESTS_GIT_TOKEN:-}" ]; then
echo "❌ ERROR: ATP_TESTS_GIT_TOKEN is not set (required to download repository archive)"
exit 1
fi
if [ -z "${ATP_TESTS_GIT_REPO_URL:-}" ]; then
echo "❌ ERROR: ATP_TESTS_GIT_REPO_URL is not set"
exit 1
fi
if [ -z "${ATP_TESTS_GIT_REPO_BRANCH:-}" ]; then
echo "❌ ERROR: ATP_TESTS_GIT_REPO_BRANCH is not set"
exit 1
fi
# Basic URL sanity check (no whitespace, http/https)
if [[ "$ATP_TESTS_GIT_REPO_URL" =~ [[:space:]] ]] || [[ ! "$ATP_TESTS_GIT_REPO_URL" =~ ^https?:// ]]; then
echo "❌ ERROR: ATP_TESTS_GIT_REPO_URL is invalid URL: $ATP_TESTS_GIT_REPO_URL"
exit 1
fi

# Strip .git from URL and extract repo name
REPO_PATH=$(echo "$ATP_TESTS_GIT_REPO_URL" | sed 's|\.git$||')
GIT_BRANCH_CLEANED=$(echo "$ATP_TESTS_GIT_REPO_BRANCH" | sed 's|/|-|')
REPO_NAME=$(basename "$REPO_PATH")
ARCHIVE_URL="${REPO_PATH}/-/archive/${ATP_TESTS_GIT_REPO_BRANCH}/${REPO_NAME}-${GIT_BRANCH_CLEANED}.zip"

if [ -z "${TMP_DIR:-}" ]; then
echo "❌ ERROR: TMP_DIR is not set"
exit 1
fi
echo "📥 Downloading archive from: $ARCHIVE_URL"
curl -sSL --fail -H "PRIVATE-TOKEN: ${ATP_TESTS_GIT_TOKEN}" "$ARCHIVE_URL" -o "$TMP_DIR/repo.zip"
mkdir -p "$TMP_DIR" 2>/dev/null || true
ZIP_PATH="$TMP_DIR/repo.zip"
CURL_ERR_PATH="$TMP_DIR/curl_download.err"

# ============================================
# Download archive with enhanced error handling
# - connect timeout: 30s
# - max time: 120s
# ============================================
HTTP_CODE="$(
curl -sS -L \
--connect-timeout 30 \
--max-time 120 \
--fail \
-H "PRIVATE-TOKEN: ${ATP_TESTS_GIT_TOKEN}" \
"$ARCHIVE_URL" \
-o "$ZIP_PATH" \
-w "%{http_code}" \
2>"$CURL_ERR_PATH"
)"
CURL_EXIT_CODE=$?

# ============================================
# Error detection and messaging
# ============================================
if [ "$CURL_EXIT_CODE" -ne 0 ]; then
CURL_ERR_MSG=""
if [ -f "$CURL_ERR_PATH" ]; then
CURL_ERR_MSG=$(tr '\n' ' ' < "$CURL_ERR_PATH" | sed 's/[[:space:]]\+/ /g' | sed 's/[[:space:]]*$//')
fi

if [[ $? -ne 0 ]]; then
echo "❌ Failed to download repository archive"
case "$CURL_EXIT_CODE" in
6)
echo "❌ ERROR: Couldn't resolve host while downloading repository archive."
;;
7)
echo "❌ ERROR: Failed to connect to host while downloading repository archive."
;;
22)
# HTTP error (4xx/5xx). We'll handle using HTTP_CODE below.
;;
28)
echo "❌ ERROR: Download timed out (connect-timeout=30s, max-time=120s)."
;;
35)
echo "❌ ERROR: SSL/TLS connection error while downloading repository archive."
;;
52)
echo "❌ ERROR: Empty reply from server while downloading repository archive."
;;
56)
echo "❌ ERROR: Network receive error while downloading repository archive."
;;
*)
echo "❌ ERROR: Network error while downloading repository archive (curl exit code: $CURL_EXIT_CODE)."
;;
esac

if [ -n "$CURL_ERR_MSG" ]; then
echo " curl: $CURL_ERR_MSG"
fi

# For non-HTTP curl failures, stop here (HTTP_CODE may be empty/undefined).
if [ "$CURL_EXIT_CODE" -ne 22 ]; then
exit 1
fi
fi

# HTTP code interpretation (also covers curl --fail exit 22)
if [ "$HTTP_CODE" != "200" ]; then
case "$HTTP_CODE" in
200)
# ok
;;
000)
echo "❌ ERROR: No HTTP response received from server (HTTP 000)."
echo " Check network connectivity and URL: $ARCHIVE_URL"
exit 1
;;
401|403)
echo "❌ ERROR: Authentication failed (HTTP $HTTP_CODE)."
echo " Check that ATP_TESTS_GIT_TOKEN is valid and has access to the repository."
exit 1
;;
404)
echo "❌ ERROR: Repository or branch not found (HTTP 404)."
echo " Check URL and branch:"
echo " - URL: $ATP_TESTS_GIT_REPO_URL"
echo " - Branch: $ATP_TESTS_GIT_REPO_BRANCH"
echo " - Archive URL: $ARCHIVE_URL"
exit 1
;;
429)
echo "❌ ERROR: Rate limited by the server (HTTP 429)."
echo " Try again later or reduce request frequency."
exit 1
;;
5??)
echo "❌ ERROR: Server error while downloading archive (HTTP $HTTP_CODE)."
echo " The Git server may be temporarily unavailable."
exit 1
;;
*)
echo "❌ ERROR: Failed to download repository archive (HTTP $HTTP_CODE, curl exit code: $CURL_EXIT_CODE)."
echo " Archive URL: $ARCHIVE_URL"
exit 1
;;
esac
fi

# ============================================
# Downloaded archive validation
# ============================================
if [ ! -f "$ZIP_PATH" ] || [ ! -s "$ZIP_PATH" ]; then
echo "❌ ERROR: Downloaded file is missing or empty: $ZIP_PATH"
exit 1
fi

if command -v file >/dev/null 2>&1; then
FILE_TYPE="$(file "$ZIP_PATH" 2>/dev/null || true)"
if ! printf '%s' "$FILE_TYPE" | grep -qi "zip archive"; then
# Git servers sometimes return an HTML login page when the token is invalid/expired.
if printf '%s' "$FILE_TYPE" | grep -qi "html"; then
echo "❌ ERROR: Downloaded an HTML login page instead of a repository."
echo " Check that ATP_TESTS_GIT_TOKEN is valid and has access to the repository."
echo " Check that the repository URL is correct."
else
echo "❌ ERROR: Downloaded repository is not recognized as a zip archive."
fi
echo " File type: $FILE_TYPE"
exit 1
fi
else
echo "⚠️ 'file' command not available; skipping zip magic-byte validation."
fi

if command -v unzip >/dev/null 2>&1; then
if ! unzip -t "$ZIP_PATH" > /dev/null 2>&1; then
echo "❌ ERROR: Archive integrity test failed (unzip -t). Please retry the operation."
exit 1
fi
else
echo "❌ ERROR: 'unzip' command is not available; cannot validate/extract archive."
exit 1
fi

echo "📦 Unzipping..."
unzip -q "$TMP_DIR/repo.zip" -d "$TMP_DIR"
unzip -q "$ZIP_PATH" -d "$TMP_DIR"
mv "$TMP_DIR"/${REPO_NAME}-${GIT_BRANCH_CLEANED}/* "$TMP_DIR"

echo "✅ Repository extracted to: $TMP_DIR"
Expand All @@ -39,11 +203,11 @@ clone_repository() {
echo "✅ Validation successful. Found 'collections/' directory in the repo."
else
echo "❌ ERROR: Neither 'app/' nor 'tests/' nor 'collections/' directory nor 'postman_collection' file found in the cloned repo!"
exit 1
exit 1
fi

# Move into the work directory
cd $TMP_DIR
cd "$TMP_DIR"

# List contents to verify
if [ -d "$TMP_DIR/app" ]; then
Expand All @@ -54,6 +218,7 @@ clone_repository() {
ls -la tests
fi


# Clear Git token from environment for security
unset ATP_TESTS_GIT_TOKEN
echo "🔐 Git token cleared from environment"
Expand Down
Loading