Skip to content

fixing security issue and null pointer dereference#39

Open
docfate111 wants to merge 1 commit intoNetflix:masterfrom
docfate111:master
Open

fixing security issue and null pointer dereference#39
docfate111 wants to merge 1 commit intoNetflix:masterfrom
docfate111:master

Conversation

@docfate111
Copy link

@docfate111 docfate111 commented Dec 28, 2020

In client/main.cpp there was a buffer overflow(using scanf into 80 character buffer) and null pointer dereference(if -o was used without arguments).

➜  client git:(master) ✗ ./dialclient -o
[1]    3818535 segmentation fault  ./dialclient -o
➜  client git:(master) ✗ ./dialclient   
Sending mcast for discovery.  Please wait for 5 seconds for the response.
Found Multiple servers
0: Rescan and list DIAL servers
1: Server IP[143.110.160.145] UUID[uuid:deadbeef-dead-beef-dead-beefdeadbeef] FriendlyName[DIAL server sample] MacAddress[86:49:98:1c:2c:d3] WakeOnLanTimeout[10]
Enter server: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
*** stack smashing detected ***: terminated
[1]    3819851 abort      ./dialclient

Small changes to client/main.cpp should fix the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant