support node.stack in nflxprofile format#107
Open
igorwwwwwwwwwwwwwwwwwwww wants to merge 1 commit intoNetflix:masterfrom
Open
support node.stack in nflxprofile format#107igorwwwwwwwwwwwwwwwwwwww wants to merge 1 commit intoNetflix:masterfrom
igorwwwwwwwwwwwwwwwwwwww wants to merge 1 commit intoNetflix:masterfrom
Conversation
Author
|
I wasn't quite sure what the intended ordering of frames in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for
node.stackin nflxprofile.The nflxprofile format supports attaching a list of stack frames to a node. As far as I can tell, this is currently ignored by flamescope, which expects one node per stack frame.
This patch will use the
node.stackif present, and otherwise fall back to the node-level value.A sample profile is attached (needs to be gunzipped to work).
test.nflxprofile.gz