Make Genie agent container's entry point and command dynamic#1251
Conversation
| when: | ||
| def entryPointTemplate = ["my", "entrypoint"] | ||
| def commandTemplate = ["my", "command"] | ||
| environment.withProperty( |
There was a problem hiding this comment.
What happens if the property is malformed?
There was a problem hiding this comment.
In that case, the Titus container will still launch, but it will fail finally. This change is mainly intended to help with testing and rolling out changes related to the entry point or command. The default values are stored in property files like application.yml, so we don't anticipate needing a long-term fast property for this scenario.
dgshep
left a comment
dgshep
left a comment
There was a problem hiding this comment.
LGTM. Docs, functionality, and tests all align. Only one question on error handling if the property isn't valid csv.
bhou2
left a comment
bhou2
left a comment
There was a problem hiding this comment.
Overall LGTM. Something nice to have is minor improvements on logging for monitoring and debugging purposes.
4 participants
Summary
Make the entry point and command properties dynamic for Titus Launcher
What changed?
genie.agent.launcher.titus.entry-point-templategenie.agent.launcher.titus.command-template