Fix conditional input paths handling for Argo DAG generation - #3052
Open
devendrakushwah80 wants to merge 7 commits into
Open
Fix conditional input paths handling for Argo DAG generation#3052devendrakushwah80 wants to merge 7 commits into
devendrakushwah80 wants to merge 7 commits into
Conversation
Contributor
Greptile SummaryThe PR changes Argo DAG input-path generation so conditional parent task IDs are resolved through Argo expressions before unresolved or empty paths are removed.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| metaflow/plugins/argo/argo_workflows.py | Generates status-aware task-ID expressions for conditional parents while retaining the existing compressed representation for ordinary parents. |
| metaflow/plugins/argo/conditional_input_paths.py | Filters unresolved template expressions and empty task-ID path segments before selecting conditional inputs. |
Reviews (5): Last reviewed commit: "git push origin fix-argo-conditional-inp..." | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Shriprasad-P
left a comment
There was a problem hiding this comment.
Review
PR: Fix conditional input paths handling for Argo DAG generation
Touched: metaflow/plugins/argo/argo_workflows.py, metaflow/plugins/argo/conditional_input_paths.py
- Addresses a concrete correctness/reliability issue based on the title and diff.
- CI/tooling change — confirm the pipeline still passes on this branch.
- Size looks manageable (+37/-12).
Commenting as a drive-by reviewer after reading the diff. Happy to look again if maintainers want a deeper pass on a specific file.
… branch 'upstream/master' into fix-argo-conditional-input-paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where unresolved {{tasks.*}} expressions
were passed into Argo DAG input paths, causing ReplaceStrict failures.
Changes:
Result: