Skip to content

recieved transaction stream in 'starknet_subscribeNewTransactions'#3059

Merged
rodrodros merged 4 commits intomainfrom
feat/stream-received-txns
Apr 6, 2026
Merged

recieved transaction stream in 'starknet_subscribeNewTransactions'#3059
rodrodros merged 4 commits intomainfrom
feat/stream-received-txns

Conversation

@EgeCaner
Copy link
Copy Markdown
Contributor

@EgeCaner EgeCaner commented Aug 14, 2025

When the RECEIVED status is included in the subscription filter of starknet_subscribeNewTransactions, the node will also stream transactions that it has forwarded to the sequencer. This PR implements the functionality to stream transactions received directly by the node.

Comment thread rpc/v6/handlers.go Outdated
Comment thread rpc/v9/subscriptions.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 15, 2025
@github-actions github-actions bot removed the Stale label Oct 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 22, 2025
@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from 3da1bc4 to facd1be Compare February 17, 2026 01:25
@EgeCaner EgeCaner changed the base branch from main to refactor/subscriptions February 17, 2026 01:26
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 69.41176% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.43%. Comparing base (303f792) to head (4f39921).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v10/subscriptions.go 53.33% 6 Missing and 1 partial ⚠️
rpc/v9/subscriptions.go 57.14% 5 Missing and 1 partial ⚠️
rpc/v10/transaction.go 50.00% 1 Missing and 2 partials ⚠️
rpc/v8/transaction.go 50.00% 1 Missing and 2 partials ⚠️
rpc/v9/transaction.go 50.00% 1 Missing and 2 partials ⚠️
rpc/v10/subscription_transactions.go 77.77% 1 Missing and 1 partial ⚠️
rpc/v9/subscription_transactions.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
- Coverage   75.47%   75.43%   -0.04%     
==========================================
  Files         384      384              
  Lines       34723    34805      +82     
==========================================
+ Hits        26206    26255      +49     
- Misses       6686     6698      +12     
- Partials     1831     1852      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from facd1be to 53dfd98 Compare February 17, 2026 02:00
@EgeCaner EgeCaner marked this pull request as ready for review February 17, 2026 02:03
@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from 53dfd98 to a2f44ae Compare February 18, 2026 15:42
Base automatically changed from refactor/subscriptions to main February 26, 2026 16:43
@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from a2f44ae to fdb0773 Compare April 1, 2026 14:49
@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from 1958058 to 287670d Compare April 2, 2026 13:52
@EgeCaner EgeCaner force-pushed the feat/stream-received-txns branch from 287670d to 5a75043 Compare April 2, 2026 14:07
Comment thread cmd/juno/juno.go
@rodrodros rodrodros force-pushed the feat/stream-received-txns branch from 5a75043 to 4f39921 Compare April 4, 2026 16:00
@rodrodros
Copy link
Copy Markdown
Contributor

Rebasing to make them run with the latest CI (new RPC sdk tests)

@rodrodros rodrodros merged commit b3eff73 into main Apr 6, 2026
27 of 28 checks passed
@rodrodros rodrodros deleted the feat/stream-received-txns branch April 6, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants