refactor(juno): integrate common interface with rawDB as trieDB engine#3187
Open
MaksymMalicki wants to merge 36 commits intomainfrom
Open
refactor(juno): integrate common interface with rawDB as trieDB engine#3187MaksymMalicki wants to merge 36 commits intomainfrom
MaksymMalicki wants to merge 36 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (25.94%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3187 +/- ##
==========================================
- Coverage 75.76% 75.07% -0.69%
==========================================
Files 386 387 +1
Lines 33748 34125 +377
==========================================
+ Hits 25569 25621 +52
- Misses 6394 6712 +318
- Partials 1785 1792 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
infrmtcs
reviewed
Oct 21, 2025
33d81d5 to
dc23482
Compare
dc23482 to
ddded14
Compare
374fcf7 to
1ba0bf0
Compare
6eb0933 to
386d97c
Compare
7740498 to
1f4a9a6
Compare
MaksymMalicki
commented
Apr 18, 2026
| }, map[felt.Felt]core.ClassDefinition{ | ||
| *classHash: simpleClass, | ||
| }, false)) | ||
| require.NoError(t, batch.Write()) |
Contributor
Author
There was a problem hiding this comment.
The new state can't read its own writes - database is used for reads. The changes applied to the batch by state.Update need to be applied to the DB.
efa09d5 to
5bc5cd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after refactor(state): remove DB writes from the new state to make writes atomic #3360
It integrates the common interfaces across the project, including in utilities and tests. This PR uses
rawDB- direct pebbleDB reads/writes - as a trieDB engine. New components of the pathDB engine will be introduced in the follow-up PRs.It introduces the new state backend for the
blockchainpackage, which utilises database for reads andBatchfor writesSome adapting had to be also done for the prove logic inside of
storage.goandstorage_test.goto support bothtrieandtrie2packages.The experimental --new-state boolean CLI flag is now fully integrated. It can be used via the command line and in the
dbcmdRevertutility.The new state package includes some minor bug fixes discovered during previous work (#2912) while debugging sync, RPC, and E2E tests.
A new command was added to the
Makefile, to run the unit tests strictly with the new state and trie implementations in the future CI/CD:NOTE:
IndexedBatch()in the diff, which is Deprecated.