Skip to content

feat(rpc): make v9 self contained#3450

Merged
thiagodeev merged 17 commits intomainfrom
thiagodeev/self-contained-rpcv9
Apr 6, 2026
Merged

feat(rpc): make v9 self contained#3450
thiagodeev merged 17 commits intomainfrom
thiagodeev/self-contained-rpcv9

Conversation

@thiagodeev
Copy link
Copy Markdown
Contributor

@thiagodeev thiagodeev commented Mar 4, 2026

Make RPC v9 self-contained, so that it no longer depends on code from v6 pkg.
Same as PR #3439, but for v9.

Note: this PR also removed the "github.com/crate-crypto/go-ipa/bandersnatch/fp" module from our code.
While I was copying the code to v9, I noticed there was this library being used only there, while the rest of the code uses the code from Consensys. This mod doesn't even have a stable release and has only a few stars on GitHub. So I decided to remove it.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 86.85714% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.42%. Comparing base (b3eff73) to head (c21cd0b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v9/simulation.go 18.18% 9 Missing ⚠️
rpc/v9/sync.go 75.86% 6 Missing and 1 partial ⚠️
rpc/v9/events.go 66.66% 4 Missing ⚠️
rpc/v9/block.go 92.85% 2 Missing ⚠️
rpc/v9/state_update.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
- Coverage   75.48%   75.42%   -0.06%     
==========================================
  Files         384      386       +2     
  Lines       34805    34907     +102     
==========================================
+ Hits        26273    26330      +57     
- Misses       6689     6731      +42     
- Partials     1843     1846       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thiagodeev thiagodeev force-pushed the thiagodeev/self-contained-rpcv9 branch from d56a373 to b173a63 Compare March 4, 2026 12:16
@thiagodeev thiagodeev changed the base branch from rdr/self-contained-rpcv10 to main March 4, 2026 12:16
@thiagodeev thiagodeev added the disable-deploy-test We don't want to run deploy tests with this PR because it might affect our development environment. label Mar 4, 2026
@thiagodeev thiagodeev removed the disable-deploy-test We don't want to run deploy tests with this PR because it might affect our development environment. label Mar 27, 2026
@thiagodeev thiagodeev force-pushed the thiagodeev/self-contained-rpcv9 branch from b173a63 to 526e60e Compare March 27, 2026 20:55
@thiagodeev thiagodeev force-pushed the thiagodeev/self-contained-rpcv9 branch 2 times, most recently from 7f98b25 to 4d3a61f Compare April 2, 2026 14:03
@thiagodeev thiagodeev marked this pull request as ready for review April 3, 2026 01:16
Comment thread rpc/v9/chain_test.go Outdated
Comment thread rpc/v6/simulation.go
@rodrodros rodrodros force-pushed the thiagodeev/self-contained-rpcv9 branch from 26f641a to 2218b93 Compare April 4, 2026 16:05
@rodrodros rodrodros force-pushed the thiagodeev/self-contained-rpcv9 branch from 2218b93 to 4bd66c4 Compare April 4, 2026 16:06
@rodrodros
Copy link
Copy Markdown
Contributor

Rebasing to run the new sdks over the PR

@rodrodros
Copy link
Copy Markdown
Contributor

Valid linter failures before we can merge

Comment thread rpc/v9/transaction.go
Copy link
Copy Markdown
Contributor

@rodrodros rodrodros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, appreciate the organized commit history

@thiagodeev thiagodeev merged commit 499b208 into main Apr 6, 2026
25 checks passed
@thiagodeev thiagodeev deleted the thiagodeev/self-contained-rpcv9 branch April 6, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants