Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
==========================================
- Coverage 75.48% 75.42% -0.06%
==========================================
Files 384 386 +2
Lines 34805 34907 +102
==========================================
+ Hits 26273 26330 +57
- Misses 6689 6731 +42
- Partials 1843 1846 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d56a373 to
b173a63
Compare
b173a63 to
526e60e
Compare
7f98b25 to
4d3a61f
Compare
rodrodros
reviewed
Apr 3, 2026
26f641a to
2218b93
Compare
…pdate handler to use them
2218b93 to
4bd66c4
Compare
Contributor
|
Rebasing to run the new sdks over the PR |
Contributor
|
Valid linter failures before we can merge |
rodrodros
reviewed
Apr 4, 2026
rodrodros
approved these changes
Apr 4, 2026
Contributor
rodrodros
left a comment
There was a problem hiding this comment.
Looks good, appreciate the organized commit history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make RPC v9 self-contained, so that it no longer depends on code from v6 pkg.
Same as PR #3439, but for v9.
Note: this PR also removed the
"github.com/crate-crypto/go-ipa/bandersnatch/fp"module from our code.While I was copying the code to v9, I noticed there was this library being used only there, while the rest of the code uses the code from Consensys. This mod doesn't even have a stable release and has only a few stars on GitHub. So I decided to remove it.