refactor(juno): obsolete the PendingData interface#3512
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
==========================================
+ Coverage 75.10% 75.46% +0.36%
==========================================
Files 386 385 -1
Lines 34923 34823 -100
==========================================
+ Hits 26228 26279 +51
+ Misses 6736 6708 -28
+ Partials 1959 1836 -123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-v2
branch
from
0c3775c to
531e909
Compare
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
2 times, most recently
from
02da98b to
22c736c
Compare
EgeCaner
reviewed
Apr 1, 2026
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-v2
branch
from
06916cd to
3bffac0
Compare
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
from
1af841f to
77b412e
Compare
EgeCaner
approved these changes
Apr 1, 2026
Contributor
EgeCaner
left a comment
EgeCaner
left a comment
There was a problem hiding this comment.
Dropped some comments, rest looks good to me
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
2 times, most recently
from
8261a14 to
1374738
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
rodrodros
reviewed
Apr 2, 2026
rodrodros
reviewed
Apr 2, 2026
EgeCaner
reviewed
Apr 2, 2026
rodrodros
requested changes
Apr 2, 2026
Contributor
rodrodros
left a comment
rodrodros
left a comment
There was a problem hiding this comment.
blocking until I do a full review
EgeCaner
reviewed
Apr 2, 2026
EgeCaner
reviewed
Apr 2, 2026
rodrodros
reviewed
Apr 2, 2026
Contributor
rodrodros
left a comment
rodrodros
left a comment
There was a problem hiding this comment.
It seems rebase was not correctly done?
rodrodros
reviewed
Apr 2, 2026
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
from
fdd32ed to
dd125fc
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
from
002d6a1 to
d277bb1
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
commented
Apr 7, 2026
|
|
||
| mockReader.EXPECT().TransactionByHash(txHash).Return(nil, db.ErrKeyNotFound) | ||
| mockSyncReader.EXPECT().PendingData().Return(nil, core.ErrPendingDataNotFound) | ||
| mockReader.EXPECT().HeadsHeader().Return(nil, db.ErrKeyNotFound) |
Contributor
Author
There was a problem hiding this comment.
The removal of the pending_data_wrapper.go allowed me to reduce the number of HeadsHeader() from 2 to 1 (called only once by the syncReader.PendingData(). No need to mock rn
MaksymMalicki
commented
Apr 7, 2026
| block, err = h.bcReader.BlockByNumber(id.Number) | ||
| } | ||
| if err != nil { | ||
| if errors.Is(err, db.ErrKeyNotFound) || errors.Is(err, core.ErrPendingDataNotFound) { |
Contributor
Author
There was a problem hiding this comment.
PendingData() for v6 now always returns an empty PendingBlock - core.ErrPendingDataNotFound is never emitted
MaksymMalicki
commented
Apr 7, 2026
| return nil, core.ErrPendingDataNotFound | ||
| } | ||
|
|
||
| func (s *Synchronizer) PendingBlock() *core.Block { |
Contributor
Author
There was a problem hiding this comment.
this was only used with tests and could simply be replaced by GetBlock() method of the preconfirmed
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
force-pushed
the
maksym/deprecate-pending-data-interface
branch
from
fcb6d74 to
c4109a3
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
rodrodros
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the follow-up to
Pendingblock deprecation. Previously, thePendingDatainterface was used through-out the project, so that both Pending and PreConfirmed blocks were accepted depending on protocol version. They were differentiated by aVariant()method . After deprecating thePendingblock, thePendingDatabecame a single-implementation interface an can be removed.Since both rpcv6 and v8 return an empty
Pendingblock forPendingData, which has no transactions, receipts and events - a no-op function is used for backward compatibility.The scope of this PR is solely to get rid of
PendingDatainterface. There will be a follow-up PR, where the naming through-out the project will be cleaned (e.g. rpc/v9/subscriptions.go -onPendingData- >onPreConfirmed). Reviewers should focus purely on correctness, as cosmetic changes were separated into another PR to reduce the noise.NOTES:
core.Pending(which is deprecated) was used in the rpcv6/v8instead ofPendingDatainterface