Skip to content

Fix missing publishedAt timestamp in Updater service #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljonesfl merged 2 commits into from
Nov 11, 2025
Merged

Fix missing publishedAt timestamp in Updater service #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1cd742
Initial plan
Copilot Nov 11, 2025
35d1d3d
Add publishedAt auto-setting to Updater service
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Cms/Services/Post/Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ public function update(
$post->setFeaturedImage( $featuredImage );
$post->setStatus( $status );

// Business rule: auto-set published date when changing to published status
if( $status === Post::STATUS_PUBLISHED && !$post->getPublishedAt() )
{
$post->setPublishedAt( new \DateTimeImmutable() );
}

// Update relationships
$categories = $this->_categoryRepository->findByIds( $categoryIds );
$post->setCategories( $categories );
Expand Down
72 changes: 72 additions & 0 deletions tests/Cms/Services/Post/UpdaterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,76 @@ public function testReturnsUpdatedPost(): void
$this->assertSame( $post, $result );
$this->assertEquals( 'Updated', $result->getTitle() );
}

public function testSetsPublishedAtWhenChangingToPublished(): void
{
$post = new Post();
$post->setId( 1 );
$post->setTitle( 'Draft Post' );
$post->setStatus( Post::STATUS_DRAFT );
// Ensure publishedAt is not set
$this->assertNull( $post->getPublishedAt() );

$this->_mockCategoryRepository
->method( 'findByIds' )
->willReturn( [] );

$this->_mockTagResolver
->method( 'resolveFromString' )
->willReturn( [] );

$this->_mockPostRepository
->expects( $this->once() )
->method( 'update' )
->with( $this->callback( function( Post $p ) {
return $p->getStatus() === Post::STATUS_PUBLISHED
&& $p->getPublishedAt() instanceof \DateTimeImmutable;
} ) );

$result = $this->_updater->update(
$post,
'Published Post',
'Body',
Post::STATUS_PUBLISHED
);

$this->assertEquals( Post::STATUS_PUBLISHED, $result->getStatus() );
$this->assertInstanceOf( \DateTimeImmutable::class, $result->getPublishedAt() );
}

public function testDoesNotOverwriteExistingPublishedAt(): void
{
$post = new Post();
$post->setId( 1 );
$post->setTitle( 'Published Post' );
$post->setStatus( Post::STATUS_PUBLISHED );
$existingPublishedAt = new \DateTimeImmutable( '2024-01-01 12:00:00' );
$post->setPublishedAt( $existingPublishedAt );

$this->_mockCategoryRepository
->method( 'findByIds' )
->willReturn( [] );

$this->_mockTagResolver
->method( 'resolveFromString' )
->willReturn( [] );

$this->_mockPostRepository
->expects( $this->once() )
->method( 'update' )
->with( $this->callback( function( Post $p ) use ( $existingPublishedAt ) {
return $p->getStatus() === Post::STATUS_PUBLISHED
&& $p->getPublishedAt() === $existingPublishedAt;
} ) );

$result = $this->_updater->update(
$post,
'Updated Published Post',
'Body',
Post::STATUS_PUBLISHED
);

$this->assertEquals( Post::STATUS_PUBLISHED, $result->getStatus() );
$this->assertSame( $existingPublishedAt, $result->getPublishedAt() );
}
}