Repository navigation
Add validation to prevent empty username/email in UserController update - #15
Merged
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: ljonesfl <1099983+ljonesfl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on code refactoring and additional tests
Add validation to prevent empty username/email in UserController update
Nov 11, 2025
ljonesfl
marked this pull request as ready for review
November 11, 2025 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UserController::update()method allowed empty strings from POST to overwrite valid credentials because$_POST['username'] ?? $user->getUsername()treats empty string as a valid value.Changes
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.