Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions samples/Directory.Packages.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<AvaloniaVersion>12.0.1</AvaloniaVersion>
<SkiaSharpVersion>3.119.3-preview.1.1</SkiaSharpVersion>
<AvaloniaVersion>12.1.0</AvaloniaVersion>
<SkiaSharpVersion>4.150.1</SkiaSharpVersion>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Avalonia" Version="$(AvaloniaVersion)" />
Expand All @@ -13,15 +13,15 @@
<PackageVersion Include="Avalonia.iOS" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.Browser" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.Android" Version="$(AvaloniaVersion)" />
<PackageVersion Include="AvaloniaUI.DiagnosticsSupport" Version="2.2.1" />
<PackageVersion Include="AvaloniaUI.DiagnosticsSupport" Version="2.2.3" />
<PackageVersion Include="SkiaSharp" Version="$(SkiaSharpVersion)" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="$(SkiaSharpVersion)" />
<PackageVersion Include="Xamarin.AndroidX.Core.SplashScreen" Version="1.2.0.2" />
<PackageVersion Include="ReactiveUI.Avalonia" Version="12.0.1" />
<PackageVersion Include="ReactiveUI.Avalonia" Version="12.1.0" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.6" />
<PackageVersion Include="Pipboy.Avalonia" Version="0.0.4-beta" />
<PackageVersion Include="ReactiveUI" Version="22.2.1" />
<PackageVersion Include="Pipboy.Avalonia" Version="1.0.0" />
<PackageVersion Include="ReactiveUI" Version="23.2.28" />
<PackageVersion Include="ReactiveUI.SourceGenerators" Version="2.5.1" />
<PackageVersion Include="ReactiveUI.WPF" Version="23.2.19" />
<PackageVersion Include="ReactiveUI.WPF" Version="23.2.28" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion samples/Sample.Common/MainWindowViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public MainWindowViewModel(IRegionManager regionManager,
public string FooterText => $"Powered by .NET {Environment.Version} • {RuntimeInformation.OSDescription}";

[Reactive]
private bool _isSplitViewPaneOpen = false;
private bool _isSplitViewPaneOpen = true;
public IObservable<bool> SupportDialog { get; } = Observable.Return(!OperatingSystem.IsBrowser());

public ObservableCollection<string> Views { get; }
Expand Down
2 changes: 1 addition & 1 deletion src/AsyncNavigation/Abstractions/IRegionManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace AsyncNavigation.Abstractions;

public interface IRegionManager
public interface IRegionManager : IDisposable
{
IReadOnlyDictionary<string, IRegion> Regions { get; }
void AddRegion(string regionName, IRegion region);
Expand Down
2 changes: 1 addition & 1 deletion src/AsyncNavigation/RegionManagerBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace AsyncNavigation;

public abstract class RegionManagerBase : IRegionManager, IDisposable
public abstract class RegionManagerBase : IRegionManager
{
private static readonly object _staticLock = new();
private static RegionManagerBase? _current;
Expand Down Expand Up @@ -360,7 +360,7 @@
return result;
}
}
catch (Exception ex) when (route.Fallback is not null)

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Test / ubuntu-latest

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Test / macos-latest

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Test / windows-latest

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Build Libraries

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Build Libraries

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Build Libraries

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (macOS)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (macOS)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (Ubuntu)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (Ubuntu)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Build WPF Library

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Build WPF Library

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Browser (WASM)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Browser (WASM)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / WPF

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / WPF

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (Windows)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Samples / Avalonia Desktop (Windows)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Pack NuGet (preview)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Pack NuGet (preview)

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Mobile / Android

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Mobile / Android

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Mobile / iOS

The variable 'ex' is declared but never used

Check warning on line 363 in src/AsyncNavigation/RegionManagerBase.cs

View workflow job for this annotation

GitHub Actions / Mobile / iOS

The variable 'ex' is declared but never used
{
return await RequestNavigateAsync(route.Fallback.RegionName, route.Fallback.ViewName, navigationParameters, replay, cancellationToken);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using AsyncNavigation.Abstractions;
using AsyncNavigation.Abstractions;
using AsyncNavigation.Core;

namespace AsyncNavigation;
namespace AsyncNavigation.Tests.Infrastructure;

/// <summary>
/// Abstract base class that provides no-op default implementations of all
Expand Down
3 changes: 1 addition & 2 deletions tests/AsyncNavigation.Tests/NavigationAwareBaseTests.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using AsyncNavigation.Abstractions;
using AsyncNavigation.Core;
using AsyncNavigation.Tests.Infrastructure;

namespace AsyncNavigation.Tests;

Expand Down
Loading