Skip to content

docs(accumulation): align ϑ/ready-queue comments with GP v0.8.0 (#1019)#1024

Merged
YCC3741 merged 1 commit into
mainfrom
fix/accumulation-1019-ready-queue-comment
Jun 28, 2026
Merged

docs(accumulation): align ϑ/ready-queue comments with GP v0.8.0 (#1019)#1024
YCC3741 merged 1 commit into
mainfrom
fix/accumulation-1019-ready-queue-comment

Conversation

@HanaYukii

@HanaYukii HanaYukii commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Part of #1012 · Closes #1019

⭐ No behaviour change — comments only (safe to skim)

internal/accumulation is already aligned with GP v0.8.0. The structural delta (full guarantees in ρ / availability-assignments, #494) already landed via #1012, and the accumulation notation fixes the issue alludes to landed back in v0.6.5 / v0.7.1.

The only change in this PR is fixing two stale comments that mislabelled blockchain.Vartheta as "available work reports". It is actually the per-epoch ready queue (GP \ready) — the cross-slot history awaiting accumulation, distinct from the just-became-available set (GetAvailableWorkReports, fed by the assurance pipeline).

Verification (why no code change)

Formula Status Evidence
eq:accinput ✅ aligned input source = assurance pipeline = GP justbecameavailable
eq:partialstate (Assign per-core) ✅ aligned ServiceIDList.Decode allocates CoresCount, decodes per-core
eq:finalstateaccumulation (gas + write-back) ✅ aligned g = max(blockaccgas, reportaccgas·CoreCount + Σ free) matches term-for-term
preimage integration ✅ aligned separate post-accumulation step in both v0.8.0 and ProcessPreimageExtrinsics

Out of scope (flagged for follow-up)

Field/getter renames to GP wording (Bless→manager, Vartheta→ready) are pre-v0.8.0 drift, cross-cutting — separate rename-only PR if wanted. VERSION_GP bump — separate.

…eady)

#1019 spec-alignment audit: the comments labelled blockchain.Vartheta as
'available work reports', but it is the per-epoch ready queue (GP \ready) —
the cross-slot history awaiting accumulation, distinct from the
just-became-available set (GetAvailableWorkReports, fed by the assurance
pipeline). Comment-only; no behaviour change.

Part of #1012
Closes #1019
@HanaYukii HanaYukii self-assigned this Jun 28, 2026

@YCC3741 YCC3741 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YCC3741
YCC3741 merged commit 48ddd98 into main Jun 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(accumulation): align GP v0.8.0 accumulation

2 participants