docs(accumulation): align ϑ/ready-queue comments with GP v0.8.0 (#1019)#1024
Merged
Conversation
…eady) #1019 spec-alignment audit: the comments labelled blockchain.Vartheta as 'available work reports', but it is the per-epoch ready queue (GP \ready) — the cross-slot history awaiting accumulation, distinct from the just-became-available set (GetAvailableWorkReports, fed by the assurance pipeline). Comment-only; no behaviour change. Part of #1012 Closes #1019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1012 · Closes #1019
⭐ No behaviour change — comments only (safe to skim)
internal/accumulationis already aligned with GP v0.8.0. The structural delta (full guarantees inρ/ availability-assignments, #494) already landed via #1012, and the accumulation notation fixes the issue alludes to landed back in v0.6.5 / v0.7.1.The only change in this PR is fixing two stale comments that mislabelled
blockchain.Varthetaas "available work reports". It is actually the per-epoch ready queue (GP\ready) — the cross-slot history awaiting accumulation, distinct from the just-became-available set (GetAvailableWorkReports, fed by the assurance pipeline).Verification (why no code change)
eq:accinputjustbecameavailableeq:partialstate(Assignper-core)ServiceIDList.DecodeallocatesCoresCount, decodes per-coreeq:finalstateaccumulation(gas + write-back)g = max(blockaccgas, reportaccgas·CoreCount + Σ free)matches term-for-termProcessPreimageExtrinsicsOut of scope (flagged for follow-up)
Field/getter renames to GP wording (
Bless→manager,Vartheta→ready) are pre-v0.8.0 drift, cross-cutting — separate rename-only PR if wanted.VERSION_GPbump — separate.