Helment#657
Merged
Merged
Conversation
|
@Qoder-Undefined Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Qoder-Undefined please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.ts: no security headers (Helmet) — API responses lack XSS protection, CSP, and other HTTP security headers
Summary
The NestJS application does not use helmet middleware. Financial APIs must send security headers to prevent clickjacking, XSS, MIME sniffing, and other client-side attacks.
What Needs to Be Done
Install helmet package: npm install helmet
Add import helmet from 'helmet' and app.use(helmet()) in main.ts before route registration
Configure contentSecurityPolicy options appropriate for an API (not a browser app)
Key Files
src/main.ts
package.json
Acceptance Criteria
helmet is installed and applied as middleware
HTTP responses include X-Frame-Options, X-Content-Type-Options, Strict-Transport-Security and other Helmet defaults
No regressions in existing API responses
closes #556