Cors#661
Merged
Merged
Conversation
|
@Qoder-Undefined Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Qoder-Undefined please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.ts: CORS is not configured — browser clients either get blocked or all origins are allowed by default
Summary
src/main.ts does not call app.enableCors(). Without explicit CORS configuration, browser-based clients cannot make cross-origin requests to the API. If a default permissive policy is applied by the runtime, it would allow any origin to call the API — equally problematic in production.
Why This Matters
Frontend applications hosted on a different origin cannot communicate with the API
Missing CORS config is a security misconfiguration for a financial API
What Needs to Be Done
Add app.enableCors({ origin: configService.get('app.allowedOrigins'), credentials: true }) in main.ts
Add ALLOWED_ORIGINS to env.validation.ts and configuration.ts
Default to a restrictive whitelist; never use origin: '*' in production
Key Files
src/main.ts
src/config/env.validation.ts
src/config/configuration.ts
.env.example
Acceptance Criteria
CORS is explicitly configured with an allowlist of origins from environment config
credentials: true is set (required for cookie-based auth flows)
ALLOWED_ORIGINS env var is documented in .env.example
closes #555