Wallets service balances#662
Merged
portableDD merged 4 commits intoMay 30, 2026
Merged
Conversation
WalletsService-balances
|
@MaryammAli Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@MaryammAli please resolve conflict |
Contributor
Author
|
@portableDD |
Contributor
Author
|
@portableDD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist Wallet Balances Using TypeORM
Overview
This PR replaces the in-memory wallet balance storage implementation with persistent database-backed storage using TypeORM entities and repositories.
Problem Addressed
The current
WalletsServicestores balances in a plain in-memoryMap, causing all wallet data to be lost whenever the application restarts, crashes, or scales horizontally.This creates a critical data-loss issue for the wallet system and makes balances unreliable in any real deployment environment.
Changes Made
Added a new
WalletBalanceTypeORM entity with the following fields:idaccountIdcurrencybalancecreatedAtupdatedAtRefactored
WalletsServiceto useInjectRepository(WalletBalance)for all balance operations.Replaced in-memory balance handling with persistent database reads/writes.
Implemented transactional
adjustBalanceupdates with optimistic locking to prevent race conditions and concurrent update inconsistencies.Replaced:
getBalancegetBalancesForAccountwith TypeORM-backed queries.
Added
TypeOrmModule.forFeature([WalletBalance])to the wallet module.Added a TypeORM migration for wallet balance persistence.
Added unit tests covering:
Key Files Updated
src/wallet/wallets.service.tssrc/wallet/wallets.types.tssrc/wallet/wallets.module.tsWalletBalanceentity and migration filesAcceptance Criteria
adjustBalanceoperations are atomic and concurrency-safe.Notes
Closes [Wave 200pts] WalletsService: balances are stored in-memory Map — all wallet data lost on every restart #549