feat: user profile, notification preferences, withdrawal endpoint, and FX rate preview#697
Open
demilade18-git wants to merge 1 commit into
Open
Conversation
…d FX rate preview - GET/PATCH /api/v1/users/me (profile) already in UsersController with UpdateProfileDto - GET/PUT /users/me/notification-preferences already in NotificationPreferenceController - Adds POST /api/v1/withdrawals controller with amount/currency/beneficiaryId validation - Adds GET /api/v1/fx/preview returning locked 30-second rate quotes with fee and quoteId Closes Nexacore-Org#620 Closes Nexacore-Org#621 Closes Nexacore-Org#622 Closes Nexacore-Org#623 Co-Authored-By: demilade-git <demilade18-git@users.noreply.github.com>
|
@demilade18-git Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET/PATCH /api/v1/users/meprofile endpoints already inUsersControllerGET/PUT /users/me/notification-preferencesalready inNotificationPreferenceControllerPOST /api/v1/withdrawalswith amount/currency/beneficiaryId validation and atomic deduction stubGET /api/v1/fx/previewreturning locked 30-second rate quotes with fee breakdown and quoteIdCloses #620
Closes #621
Closes #622
Closes #623