fix: remove stale mock transactions file and unify AdminSidebar icon …#163
Open
Jay1280 wants to merge 2 commits into
Open
fix: remove stale mock transactions file and unify AdminSidebar icon …#163Jay1280 wants to merge 2 commits into
Jay1280 wants to merge 2 commits into
Conversation
…pattern Closes Nexacore-Org#156 - Delete stale app/lib/api/transactions.ts mock file - Delete empty app/lib/api directory - Update AdminSidebar to use consistent icon pattern (icon: X instead of icon: null, lucide: X) - Fix all imports from deleted mock file to point to real lib/api/transactions - Remove date filtering from transactions page (real API doesn't support it) - Fix useFocusTrap type to accept nullable RefObject
|
@Jay1280 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Jay1280 resolve conflicts |
Contributor
|
@Jay1280 please resolve conflicts |
Resolved merge conflicts: - Updated transaction page imports to use correct component paths - Removed duplicate transaction components from app/components - Fixed import paths for csv-export utility - Integrated changes from main branch while preserving our fixes
Contributor
|
@Jay1280 please fix the ci error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pattern
Closes #156