feat: #177 Secure DEV_TOKEN proxy with NODE_ENV guard and add .env.ex…#180
Merged
portableDD merged 1 commit intoMay 30, 2026
Conversation
… add .env.example warning - Add NODE_ENV guard to only use TEST_ACCESS_TOKEN in development - Prevent unauthorized access via dev token fallback in production/staging - Add comprehensive security warning to .env.example - Document security implications in proxy source file with JSDoc comment This prevents a critical security vulnerability where unauthenticated requests could be authorized using the dev token in deployed environments.
|
@amankoli09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177
🔒 Security Fix: DEV_TOKEN Proxy Fallback Restriction
This PR addresses a critical security vulnerability where the API proxy could authorize unauthenticated requests using a development token in production/staging environments.
Problem
The proxy had a DEV_TOKEN fallback that would be used for all requests if set, regardless of environment. If
TEST_ACCESS_TOKENwas accidentally deployed on Render or production, every request from unauthenticated users would be authorized, leaking:Solution
✅ Added
NODE_ENV === "development"guard to DEV_TOKEN fallback✅ Added security warning to
.env.example✅ Added detailed JSDoc documentation in proxy source
Changes
Testing
Acceptance Criteria