Skip to content

User avatar in chat search and no chat title duplicate#99

Open
KMohZaid wants to merge 1 commit into
NextAlone:mainfrom
KMohZaid:feature/user-avatar-in-chat-search
Open

User avatar in chat search and no chat title duplicate#99
KMohZaid wants to merge 1 commit into
NextAlone:mainfrom
KMohZaid:feature/user-avatar-in-chat-search

Conversation

@KMohZaid

Copy link
Copy Markdown

User avatar in chat search and no chat title duplicate

Show other user avatar for in chat searches and doesn't show chat title in them (chat title was repeating in all results and they are obvious same)

Description

When we search for messages in group chat, result list show group avatar and title in all results of other users. Which make it hard to identify who is user

In the code, DialogCell have useFromUserAsAvatar which if set to true will display user avatar not chat avatar. It's set to true in MessageSearchAdapter (in chat search) so it shows avatar.

And in DialogCell logic, nameString is set to user's name if useFromUserAsAvatar is true but chat is not forum to move user's name on title row of cell. And pretty large if condition is changed to avoid adding user's name from message row of cell.

Issues Fixed or Closed by This PR

Check List

  • I have tested the changes and verified that they work and don't break anything(as well as I can manage) or drop the support for previous versions.
  • My code follows the code style of this project
  • I have merged commits that are meaningless for follow-up work and confirmed that they will not cause damage to follow-up maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant