User avatar in chat search and no chat title duplicate#99
Open
KMohZaid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User avatar in chat search and no chat title duplicate
Show other user avatar for in chat searches and doesn't show chat title in them (chat title was repeating in all results and they are obvious same)
Description
When we search for messages in group chat, result list show group avatar and title in all results of other users. Which make it hard to identify who is user
In the code, DialogCell have useFromUserAsAvatar which if set to true will display user avatar not chat avatar. It's set to true in MessageSearchAdapter (in chat search) so it shows avatar.
And in DialogCell logic, nameString is set to user's name if useFromUserAsAvatar is true but chat is not forum to move user's name on title row of cell. And pretty large if condition is changed to avoid adding user's name from message row of cell.
Issues Fixed or Closed by This PR
Check List