Skip to content

Localize Spark starter copy defaults #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
next-devin merged 2 commits into from
Jun 21, 2026
Merged

Localize Spark starter copy defaults #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd5102
Localize Spark starter copy defaults
next-devin Jun 21, 2026
0509bec
Address localization review feedback
next-devin Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions configs/settings_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,26 @@
"homepage_hero_overlay_opacity": 30,
"homepage_hero_alt": "",
"homepage_hero_link": "",
"homepage_hero_cta": "Shop now",
"homepage_hero_cta_style": "primary",
"homepage_hero_cta_outline": false,
"featured_product": null,
"featured_product_header": "",
"featured_product_header_size": "medium",
"featured_product_header_align": "left",
"featured_product_description": "",
"featured_product_cta_text": "View Product",
"featured_product_cta_style": "primary",
"featured_product_cta_outline": false,
"featured_product_bg_color": "",
"featured_products": [],
"featured_products_header": "Featured Products",
"featured_products_header_size": "medium",
"featured_products_header_align": "left",
"featured_products_columns": 3,
"featured_products_bg_color": "",
"featured_products_card_bg": "",
"featured_products_cta_text": "View All",
"featured_products_cta_url": "",
"featured_products_cta_style": "primary",
"featured_products_cta_outline": true,
"featured_categories": [],
"featured_categories_header": "Shop by Category",
"featured_categories_header_size": "medium",
"featured_categories_header_align": "left",
"featured_categories_columns": 2,
Expand All @@ -56,7 +51,6 @@
"product_card_border": false,
"product_reviews": true,
"show_recommended": true,
"recommended_products_header": "Recommended Products",
"recommended_products_header_size": "medium",
"recommended_products_header_align": "left",
"recommended_products_columns": 3,
Expand All @@ -72,7 +66,6 @@
"ab_bg_color": "",
"ab_text_color": "",
"ab_link": "",
"ab_link_text": "Learn more",
"ab_placement": "all",
"footer_menu": "footer_menu",
"footer_bg_color": "",
Expand All @@ -95,33 +88,25 @@
"body_text_color": "",
"body_header_color": "",
"body_link_color": "",
"cart_header_title": "Your Cart",
"sidecart_open_on_add": true,
"enable_progress_bar": false,
"usd_goal_1": 50,
"usd_goal_2": 100,
"step_1_message": "You are {amount} away from FREE shipping",
"step_2_message": "You are {amount} away from a FREE gift!",
"final_step_message": "You have unlocked all rewards!",
"gift_product": null,
"enable_upsells": false,
"upsell_section_title": "You May Also Like",
"upsell_fallback_slots": "1,2",
"upsell_product_1": null,
"upsell_product_2": null,
"upsell_product_3": null,
"show_on_sale": false,
"on_sale_header": "On Sale",
"on_sale_header_size": "medium",
"on_sale_header_align": "left",
"on_sale_products": [],
"on_sale_columns": 3,
"on_sale_bg_color": "",
"on_sale_card_bg": "",
"show_promo_banner": false,
"promo_banner_heading": "",
"promo_banner_subheading": "",
"promo_banner_cta_text": "Shop Now",
"promo_banner_cta_url": "",
"promo_banner_bg_color": "",
"promo_banner_text_color": "",
Expand Down
63 changes: 23 additions & 40 deletions configs/settings_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,8 @@
"name": "homepage_hero_cta",
"label": "Hero Button Text",
"type": "text",
"help_text": "Call-to-action button text.",
"max_length": 50,
"default": "Shop now"
"help_text": "Call-to-action button text. Leave blank to use the localized default.",
"max_length": 50
},
{
"name": "homepage_hero_cta_style",
Expand Down Expand Up @@ -264,7 +263,7 @@
"name": "featured_product_header",
"label": "Section Heading",
"type": "text",
"help_text": "Heading above the featured product. Leave blank to hide.",
"help_text": "Heading above the featured product. Leave blank to use the localized default.",
"max_length": 250
},
{
Expand Down Expand Up @@ -320,9 +319,8 @@
"name": "featured_product_cta_text",
"label": "Button Text",
"type": "text",
"help_text": "Call-to-action button text.",
"max_length": 100,
"default": "View Product"
"help_text": "Call-to-action button text. Leave blank to use the localized default.",
"max_length": 100
},
{
"name": "featured_product_cta_style",
Expand Down Expand Up @@ -366,9 +364,8 @@
"name": "featured_products_header",
"label": "Section Heading",
"type": "text",
"help_text": "Heading above the featured products grid. Leave blank to hide.",
"max_length": 250,
"default": "Featured Products"
"help_text": "Heading above the featured products grid. Leave blank to use the localized default.",
"max_length": 250
},
{
"name": "featured_products_header_size",
Expand Down Expand Up @@ -439,8 +436,7 @@
"name": "featured_products_cta_text",
"label": "Button Text",
"type": "text",
"default": "View All",
"help_text": "Optional button text shown below the grid.",
"help_text": "Optional button text shown below the grid. Leave blank to use the localized default.",
"max_length": 100
},
{
Expand Down Expand Up @@ -480,8 +476,7 @@
"name": "on_sale_header",
"label": "Section Heading",
"type": "text",
"default": "On Sale",
"help_text": "Heading above the on-sale products grid.",
"help_text": "Heading above the on-sale products grid. Leave blank to use the localized default.",
"max_length": 250
},
{
Expand Down Expand Up @@ -561,8 +556,7 @@
"name": "promo_banner_heading",
"label": "Heading",

@kilo-code-bot kilo-code-bot Bot Jun 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Removing the default for promo_banner_heading is inconsistent with the rest of this PR. Every other removed default is paired with a {% t %} fallback in the corresponding template (section_hero.html, section_featured_products.html, section_featured_categories.html, section_on_sale.html, block_cart_upsell.html, etc.). Here, partials/section_promo_banner.html still uses the heading as a section-render gate and has no localized fallback — so dropping the default means the banner disappears for new installs.

Either drop promo_banner_heading from STARTER_COPY_SETTINGS (i.e., restore the default) or update the template to render a localized fallback heading.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

"type": "text",
"default": "Limited Time Offer",
"help_text": "Large heading text on the promo banner.",
"help_text": "Large heading text on the promo banner. Leave blank to use the localized default.",
"max_length": 100
},
{
Expand All @@ -576,8 +570,7 @@
"name": "promo_banner_cta_text",
"label": "Button Text",
"type": "text",
"default": "Shop Now",
"help_text": "Call-to-action button label.",
"help_text": "Optional button text shown in the promo banner. Leave blank to use the localized default.",
"max_length": 50
},
{
Expand Down Expand Up @@ -635,9 +628,8 @@
"name": "featured_categories_header",
"label": "Section Heading",
"type": "text",
"help_text": "Heading above the featured categories. Leave blank to hide.",
"max_length": 250,
"default": "Shop by Category"
"help_text": "Heading above the featured categories. Leave blank to use the localized default.",
"max_length": 250
},
{
"name": "featured_categories_header_size",
Expand Down Expand Up @@ -848,16 +840,14 @@
"name": "membership_label",
"label": "Member Price Label",
"type": "text",
"default": "Member price",
"help_text": "Short label shown beside the member price.",
"help_text": "Short label shown beside the member price. Leave blank to use the localized default.",
"max_length": 80
},
{
"name": "membership_detail_text",
"label": "Member Price Detail",
"type": "text",
"default": "Applied at checkout",
"help_text": "Optional detail shown on larger price surfaces.",
"help_text": "Optional detail shown on larger price surfaces. Leave blank to use the localized default.",
"max_length": 120
}
],
Expand All @@ -881,8 +871,7 @@
"name": "recommended_products_header",
"label": "Section Heading",
"type": "text",
"default": "Recommended Products",
"help_text": "Heading above the recommended products grid. Leave blank to use the default translation.",
"help_text": "Heading above recommended products. Leave blank to use the localized default.",
"max_length": 250
},
{
Expand Down Expand Up @@ -1171,8 +1160,7 @@
"name": "cart_header_title",
"label": "Header Title",
"type": "text",
"default": "Your Cart",
"help_text": "Title displayed at the top of the side cart.",
"help_text": "Title displayed at the top of the side cart. Leave blank to use the localized default.",
"max_length": 50
},
{
Expand Down Expand Up @@ -1209,24 +1197,21 @@
"name": "step_1_message",
"label": "Free Shipping Message",
"type": "text",
"default": "You are {amount} away from FREE shipping",
"help_text": "Message shown when cart is below the shipping threshold. Use {amount} for the remaining amount.",
"help_text": "Message shown when cart is below the shipping threshold. Use {amount} for the remaining amount. Leave blank to use the localized default.",
"max_length": 200
},
{
"name": "step_2_message",
"label": "Free Gift Message",
"type": "text",
"default": "You are {amount} away from a FREE gift!",
"help_text": "Message shown when cart is between shipping and gift thresholds. Use {amount} for the remaining amount.",
"help_text": "Message shown when cart is between shipping and gift thresholds. Use {amount} for the remaining amount. Leave blank to use the localized default.",
"max_length": 200
},
{
"name": "final_step_message",
"label": "All Rewards Reached Message",
"type": "text",
"default": "You have unlocked all rewards!",
"help_text": "Celebration message shown when the cart total exceeds all milestones.",
"help_text": "Celebration message shown when the cart total exceeds all milestones. Leave blank to use the localized default.",
"max_length": 200
},
{
Expand All @@ -1248,8 +1233,7 @@
"name": "upsell_section_title",
"label": "Section Title",
"type": "text",
"default": "You May Also Like",
"help_text": "Heading displayed above suggested products in the side cart.",
"help_text": "Heading displayed above suggested products in the side cart. Leave blank to use the localized default.",
"max_length": 100
},
{
Expand Down Expand Up @@ -1404,9 +1388,8 @@
"name": "ab_link_text",
"label": "Link Text",
"type": "text",
"help_text": "Text for the announcement link.",
"max_length": 100,
"default": "Learn more"
"help_text": "Text for the announcement link. Leave blank to use the localized default.",
"max_length": 100
},
{
"name": "ab_placement",
Expand Down
8 changes: 4 additions & 4 deletions layouts/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,16 @@
{% if settings.enable_membership_pricing %}
{% url 'storefrontapi:graphql' as membership_graphql_url %}
<script>
{% t 'membership.price_label' as spark_membership_price_label %}
{% t 'membership.applied_at_checkout' as spark_membership_applied_at_checkout %}
{% t 'membership.price_label' as default_membership_label %}
{% t 'membership.applied_at_checkout' as default_membership_detail_text %}
window.SparkMembershipPricingConfig = {
enabled: true,
graphqlUrl: "{{ membership_graphql_url|default:'/api/graphql/'|escapejs }}",
discountPercent: "{{ settings.membership_discount_percent|default:"25"|escapejs }}",
statusMetadataKey: "{{ settings.membership_status_metadata_key|default:"uvbrite_member_status"|escapejs }}",
activeStatusValue: "{{ settings.membership_active_status_value|default:"active"|escapejs }}",
label: "{% if settings.membership_label %}{{ settings.membership_label|escapejs }}{% else %}{{ spark_membership_price_label|escapejs }}{% endif %}",
detailText: "{% if settings.membership_detail_text %}{{ settings.membership_detail_text|escapejs }}{% else %}{{ spark_membership_applied_at_checkout|escapejs }}{% endif %}"
label: "{{ settings.membership_label|default:default_membership_label|escapejs }}",
detailText: "{{ settings.membership_detail_text|default:default_membership_detail_text|escapejs }}"
};
</script>
<script type="text/javascript" src="{{ 'js/spark-membership-pricing.js'|asset_url }}" defer></script>
Expand Down
15 changes: 11 additions & 4 deletions locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
"terms_conditions": "Allgemeine Geschäftsbedingungen",
"privacy": "Datenschutzrichtlinie",
"address": "Adresse",
"copyright": "Alle Rechte vorbehalten"
"copyright": "Alle Rechte vorbehalten",
"help": "Hilfezentrum",
"rights": "Alle Rechte vorbehalten."
},
"pagination": {
"next": "Weiter"
Expand Down Expand Up @@ -156,7 +158,7 @@
"customer_reviews": "Bewertungen von Kunden",
"see_all_reviews": "Alle Bewertungen ansehen",
"write_a_review": "Schreibe eine Rezension",
"recommended_products_header": "Kunden, die diesen Artikel angesehen haben, kauften auch",
"recommended_products_header": "Empfohlene Produkte",
"apply_filters": "Filter anwenden",
"description": "Beschreibung",
"filter_reset": "Zurücksetzen",
Expand Down Expand Up @@ -247,7 +249,8 @@
"invalid_coupon_code": "Ungültiger Gutscheincode",
"shipping_progress_message": "Sie sind {amount} vom KOSTENLOSEN Versand entfernt",
"gift_progress_message": "Sie sind {amount} von einem KOSTENLOSEN Geschenk entfernt",
"final_progress_message": "Sie haben alle Prämien freigeschaltet"
"final_progress_message": "Sie haben alle Prämien freigeschaltet",
"upsell_section_title": "Das könnte dir auch gefallen"
}
},
"footer": {
Expand Down Expand Up @@ -277,7 +280,11 @@
"view_product": "Produkt ansehen"
},
"heading": {
"on_sale": "Im Angebot"
"on_sale": "Im Angebot",
"featured_products": "Ausgewählte Produkte",
"featured_categories": "Nach Kategorie einkaufen",
"promo_banner": "Zeitlich begrenztes Angebot",
"featured_product": "Ausgewähltes Produkt"
},
"placeholder": {
"hero_image": "Hero-Bild",
Expand Down
11 changes: 8 additions & 3 deletions locales/en.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
"customer_reviews": "Customer Reviews",
"see_all_reviews": "See all reviews",
"write_a_review": "Write a review",
"recommended_products_header": "Customers who viewed this item also bought",
"recommended_products_header": "Recommended products",
"apply_filters": "Apply filters",
"description": "Description",
"filter_reset": "Reset",
Expand Down Expand Up @@ -249,7 +249,8 @@
"invalid_coupon_code": "Invalid coupon code",
"shipping_progress_message": "You are {amount} away from FREE shipping",
"gift_progress_message": "You are {amount} away from a FREE gift!",
"final_progress_message": "You have unlocked all rewards!"
"final_progress_message": "You have unlocked all rewards!",
"upsell_section_title": "You may also like"
}
},
"footer": {
Expand Down Expand Up @@ -279,7 +280,11 @@
"view_product": "View product"
},
"heading": {
"on_sale": "On sale"
"on_sale": "On sale",
"featured_products": "Featured products",
"featured_categories": "Shop by category",
"promo_banner": "Limited-time offer",
"featured_product": "Featured product"
},
"placeholder": {
"hero_image": "Hero image",
Expand Down
Loading
Loading