Skip to content

Clean up localization review follow-up #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
next-devin merged 1 commit into from
Jun 21, 2026
Merged

Clean up localization review follow-up #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Einstellungen > Homepage > Hero-Bild",
"featured_products": "Ausgewählte Produkte - Einstellungen > Homepage > Ausgewählte Produkte",
"featured_categories": "Ausgewählte Kategorien - Einstellungen > Homepage > Ausgewählte Kategorien",
"promo_banner": "Promo-Banner - Einstellungen > Homepage > Promo-Banner > Überschrift",
"on_sale": "Im Angebot - Einstellungen > Homepage > Im Angebot > Produkte",
"featured_product": "Ausgewähltes Produkt - Einstellungen > Homepage > Ausgewähltes Produkt"
}
Expand Down
1 change: 0 additions & 1 deletion locales/en.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Configuración > Inicio > Imagen principal",
"featured_products": "Productos destacados - Configuración > Inicio > Productos destacados",
"featured_categories": "Categorías destacadas - Configuración > Inicio > Categorías destacadas",
"promo_banner": "Banner promocional - Configuración > Inicio > Banner promocional > Encabezado",
"on_sale": "En oferta - Configuración > Inicio > En oferta > Productos",
"featured_product": "Producto destacado - Configuración > Inicio > Producto destacado"
}
Expand Down
1 change: 0 additions & 1 deletion locales/fi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Paramètres > Accueil > Image principale",
"featured_products": "Produits en vedette - Paramètres > Accueil > Produits en vedette",
"featured_categories": "Catégories en vedette - Paramètres > Accueil > Catégories en vedette",
"promo_banner": "Bannière promotionnelle - Paramètres > Accueil > Bannière promotionnelle > Titre",
"on_sale": "En promotion - Paramètres > Accueil > En promotion > Produits",
"featured_product": "Produit en vedette - Paramètres > Accueil > Produit en vedette"
}
Expand Down
1 change: 0 additions & 1 deletion locales/it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/no.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/pt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/sv.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
1 change: 0 additions & 1 deletion locales/th.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
"hero_image_path": "Settings > Homepage > Hero Image",
"featured_products": "Featured Products - Settings > Homepage > Featured Products",
"featured_categories": "Featured Categories - Settings > Homepage > Featured Categories",
"promo_banner": "Promo Banner - Settings > Homepage > Promo Banner > Heading",
"on_sale": "On Sale - Settings > Homepage > On Sale > Products",
"featured_product": "Featured Product - Settings > Homepage > Featured Product"
}
Expand Down
6 changes: 5 additions & 1 deletion tests/test_localization_contracts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,14 @@ def template_paths():

def localized_default_settings_from_templates():
settings = set()
localized_default_vars = set()

for path in template_paths():
text = path.read_text()
localized_default_vars.update(LOCALIZED_DEFAULT_ASSIGNMENT_PATTERN.findall(text))

for path in template_paths():
text = path.read_text()
localized_default_vars = set(LOCALIZED_DEFAULT_ASSIGNMENT_PATTERN.findall(text))
for setting_name, default_var in SETTING_DEFAULT_PATTERN.findall(text):
if default_var in localized_default_vars:
settings.add(setting_name)
Expand Down
Loading