Skip to content

CAQR sub-routines and tests #10

Merged
Rabab53 merged 3 commits into
mainfrom
fda/caqr
Aug 26, 2025
Merged

CAQR sub-routines and tests #10
Rabab53 merged 3 commits into
mainfrom
fda/caqr

Conversation

@fda-tome
Copy link
Copy Markdown
Collaborator

This PR adds many triangular on top of square (TS), triangular on top of triangular (TT), and some more basic QR kernels with proper testing, this is heavily based on the work done by @Azura-yuwi and @AkhilAkkapelli.

@Rabab53
Copy link
Copy Markdown
Collaborator

Rabab53 commented Jul 22, 2025

Thanks so much, everyone.

Regarding function naming, I would strongly prefer removing the z prefix from all function names. In the PLASMA package, the z prefix was conventionally used to denote double complex data types, and the remaining precisions were generated via Python scripts.

However, in Julia, we rely on type inference and multiple dispatch, so there’s no need to encode the data type in the function name. Therefore, I recommend omitting the z prefix in NextLA for consistency with Julia’s design philosophy.

I’ll make sure to test all functions and ensure they pass the test suite after the renaming.

@Rabab53
Copy link
Copy Markdown
Collaborator

Rabab53 commented Aug 1, 2025

@fda-tome Please expand the testing matrix sizes and remove z prefix from all function names.

@fda-tome
Copy link
Copy Markdown
Collaborator Author

@Rabab53 thank you for point out the mistakes, I corrected the names and made the sizes bigger

@Rabab53 Rabab53 merged commit 6ca2c4d into main Aug 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants