fix: resolve typecheck errors blocking CI - #2
Merged
Conversation
- add missing deps: adm-zip, lucide-react, @types/adm-zip (apps/web) - pin @types/react/react-dom to v19 via pnpm overrides to fix React 18/19 ReactNode clash - DefaultLayout: accept customizations prop to match LoadedTheme layout type - use-autosave: provide initial value to useRef (React 19 types) - auth config: cast session.user through unknown - heading block: import JSX type from react (React 19 global namespace move)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the pre-existing
Validate(typecheck) failures that block CI onmain. 16 errors across 7 files, all resolved.Changes
apps/web:adm-zip,lucide-react, and@types/adm-zip(were imported but never declared →TS2307, and cascading implicit-anyon adm-zip entry callbacks).TS2322inadmin-providers.tsx): pinned@types/react/@types/react-domto v19 via rootpnpm.overrides, removing the duplicated@types/react@18pulled in transitively.theme-manager.ts(TS2322):DefaultLayoutnow accepts thecustomizationsprop so it matchesComponentType<{ children; customizations }>.use-autosave.ts(TS2554):useRefgiven an explicit initialundefined(React 19 types require an argument).lib/auth/config.ts(TS2352): session-user cast routed throughunknownwhile keeping thesatisfies SessionUsercheck.heading.tsx(TS2503): importJSXtype fromreact(the globalJSXnamespace moved under React 19 types).Verification
pnpm turbo typecheck→ 7/7 packages pass locally.pnpm --filter @nextpress/db exec prisma validate→ schema valid.⛩️ Generated with ehAye Dojo 🚀