Repository navigation
fix(mobile): css batch 2 — the phone layout fixes from the 3.5.3 screenshots - #1683
Merged
Merged
Conversation
This was referenced Oct 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the phone css batch thibs, c5pie and gzetk reported (22 screenshots, all on 3.5.3). every item was measured in chromium at 390/360/320 before and after, not eyeballed.
six root causes:
folded in from two hostile review rounds: the phone transport sizing initially crushed the player's stop button (a text pill, not a transport circle) — scoped to the controls row; three more modal families added to the hamburger coverage (watchlist-add, server-disambiguation, genre browser); 320px residuals fixed (tools mode toggle, audiobooks search modes, downloads step name).
tests: 30 new css/tsx pinning tests (28 fail on the base), npm run check clean, full vitest suite green (10,268). phone screenshot baselines in ci will diff on the touched pages — the layouts changed on purpose; desktop is untouched (everything is inside phone media queries, the exclusion list, or phone-only rules).
note: the reporters are on 3.5.3, so the #1661 fixes they also don't have yet (ios input zoom, import rail scroll, video wishlist rail) will keep looking broken to them until a release ships both.