docs(plan): defer live-terminal wiring until after bootstrap (step 4) - #13
Open
NiDrZero wants to merge 1 commit into
Open
docs(plan): defer live-terminal wiring until after bootstrap (step 4)#13NiDrZero wants to merge 1 commit into
NiDrZero wants to merge 1 commit into
Conversation
… bootstrap Step 3 (app shell) is complete except the live-terminal wiring (AndroidView + TerminalSession execing a shell). That wiring is intentionally held until step 4 (bootstrap) lands, because the terminal engine can only draw a shell if a real shell binary exists on disk. Until the bootstrap payload ships, the only guaranteed binary is Android's minimal /system/bin/sh; wiring against it now would be throwaway work. We do the bootstrap first, then wire the terminal once against the real shell. Documents that the completion of step 3's wiring lives under step 4 and needs an on-device cold-start check (not possible in CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does (plain English)
Docs only. Records the decision to hold the live-terminal wiring (old PR D)
until after the bootstrap payload lands (step 4), and explains why, so future-
you (or a future session) doesn't re-litigate it or accidentally start the
throwaway version.
The reasoning, in short
The terminal engine can only draw a shell if there is a real shell binary on
disk to run. Until the bootstrap payload ships, the only binary guaranteed to
exist on any device is Android's built-in
/system/bin/sh— a real shell, butminimal (no package manager, almost no tools). Wiring the terminal against that
now and then rewiring it against the real glibc shell after bootstrap would be
throwaway work. So: do the bootstrap first, wire the terminal once.
Until then, the Terminal tab keeps its deliberate placeholder — it never
pretends to be a working shell.
What changed
Atomux_Build_Plan.md, Build Order:live-terminal wiring is deferred, with the reasoning above.
right after bootstrap, and flagged it needs an on-device cold-start check
(keystrokes in, output rendered) that CI cannot perform.
Not merging
Left open for your review.