fix: remove leading indentation from exercise files (#54)#99
Open
NicksPatties wants to merge 1 commit into
Open
fix: remove leading indentation from exercise files (#54)#99NicksPatties wants to merge 1 commit into
NicksPatties wants to merge 1 commit into
Conversation
scanFileText read file content but never stripped leading whitespace, forcing users to type unnecessary spaces for indented language files like Go. Added util.DedentLines call to strip minimum common indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bug #54: Sources that start indented (like Go code files) forced users to type all the leading whitespace, defeating the auto-indent feature.
Root Cause
scanFileText() in cmd/root/sweet.go read file content and joined lines with newlines, but never stripped leading whitespace. DedentLines() already existed in the util package (used by the add command) but wasn't applied during exercise execution.
Fix
Added util.DedentLines(lines) call in scanFileText to remove the minimum common indentation from all lines before returning the exercise text.
Changes
Closes #54